Skip to content

Define TARGET macro the same even when computed goto support is not enabled #88226

Description

@smontanaro
BPO 44060
Nosy @smontanaro
PRs
  • bpo-44060: Enable TARGET labels even when not using computed gotos. #25949
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2021-05-06.15:09:57.774>
    labels = ['interpreter-core', 'type-feature', '3.11']
    title = 'Define TARGET macro the same even when computed goto support is not enabled'
    updated_at = <Date 2021-05-06.15:49:48.011>
    user = 'https://github.com/smontanaro'

    bugs.python.org fields:

    activity = <Date 2021-05-06.15:49:48.011>
    actor = 'skip.montanaro'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Interpreter Core']
    creation = <Date 2021-05-06.15:09:57.774>
    creator = 'skip.montanaro'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 44060
    keywords = ['patch']
    message_count = 1.0
    messages = ['393099']
    nosy_count = 1.0
    nosy_names = ['skip.montanaro']
    pr_nums = ['25949']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue44060'
    versions = ['Python 3.11']

    Activity

    1. smontanaro commented on May 6, 2021

      @smontanaro
      ContributorAuthor

      When the interpreter is compiled with computed goto support, the TARGET macro is defined like this:

      #define TARGET(op) op: TARGET_##op

      If computed gotos are disabled, the implementation is simpler:

      #define TARGET(op) op

      I'm finding it useful to use those labels as gdb breakpoint targets. Is there some reason not to always define the TARGET_##op label?

    2. added
      3.11only security fixes
      interpreter-core(Objects, Python, Grammar, and Parser dirs)
      type-featureA feature request or enhancement
      on May 6, 2021
    3. transferred this issue fromon Apr 10, 2022
    4. added a commit that references this issue on Nov 22, 2022
    5. added
      3.12only security fixes
      and removed
      3.11only security fixes
      on Nov 22, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.12only security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancement

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions