Repository navigation
Use functools.lru_cache in urllib.parse instead of 1996 custom caching #88168
Description
| BPO | 44002 |
|---|---|
| Nosy | @gpshead |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/gpshead'
closed_at = <Date 2021-05-12.00:02:19.781>
created_at = <Date 2021-05-01.18:17:15.725>
labels = ['type-feature', 'library', '3.11']
title = 'Use functools.lru_cache in urllib.parse instead of 1996 custom caching'
updated_at = <Date 2021-05-12.00:02:19.781>
user = 'https://github.com/gpshead'bugs.python.org fields:
activity = <Date 2021-05-12.00:02:19.781>
actor = 'gregory.p.smith'
assignee = 'gregory.p.smith'
closed = True
closed_date = <Date 2021-05-12.00:02:19.781>
closer = 'gregory.p.smith'
components = ['Library (Lib)']
creation = <Date 2021-05-01.18:17:15.725>
creator = 'gregory.p.smith'
dependencies = []
files = []
hgrepos = []
issue_num = 44002
keywords = ['patch']
message_count = 3.0
messages = ['392614', '392619', '392620']
nosy_count = 1.0
nosy_names = ['gregory.p.smith']
pr_nums = ['25798']
priority = 'normal'
resolution = 'fixed'
stage = 'commit review'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue44002'
versions = ['Python 3.11']
Activity
gpshead commentedon May 1, 2021
urllib.parsehas custom caching code for bothurlsplit()andquote(). From 1996.3fd32ec
7449540
with a truthful comment added by Nick in 2010 that we should just use functools.lru_cache.
9fc443c#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
time to clean up this cruft and do that.
I'm waiting for after the 3.10 cut and a still in progress urllib.parse security fix to land before rebasing my soon to be attached PR to avoid code conflicts.
rhettinger commentedon May 1, 2021
While you're cleaning up the module, take a look at the Quoter class. It overrides __init__ and __missing__, so Quoter is not using any of the defaultdict features at all. I'm thinking it could just inherit from dict.
gpshead commentedon May 1, 2021
Yeah, the Quoter class seems a little odd...
Past notes of some the caching performance around the character quoting for quote() can be found in https://bugs.python.org/issue1285086 circa 2005-2010.