Repository navigation
Incorrect handling of PyObject_RichCompareBool() in the _zoneinfo module #87298
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2021-02-04.23:48:01.917>
labels = ['extension-modules', 'type-bug', '3.9', '3.10']
title = 'Incorrect handling of PyObject_RichCompareBool() in the _zoneinfo module'
updated_at = <Date 2021-03-11.22:56:35.067>
user = 'https://github.com/ZackerySpytz'bugs.python.org fields:
activity = <Date 2021-03-11.22:56:35.067>
actor = 'ZackerySpytz'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules']
creation = <Date 2021-02-04.23:48:01.917>
creator = 'ZackerySpytz'
dependencies = []
files = []
hgrepos = []
issue_num = 43132
keywords = ['patch']
message_count = 6.0
messages = ['386503', '386517', '386531', '386535', '386548', '386590']
nosy_count = 4.0
nosy_names = ['serhiy.storchaka', 'p-ganssle', 'ZackerySpytz', 'miss-islington']
pr_nums = ['24450', '24457', '24829']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue43132'
versions = ['Python 3.9', 'Python 3.10']
Activity
ZackerySpytz commentedon Feb 4, 2021
PyObject_RichCompareBool() returns -1 on error, but this case is not handled
by the find_in_strong_cache() function.
serhiy-storchaka commentedon Feb 5, 2021
New changeset effaec0 by Zackery Spytz in branch 'master':
bpo-43132: Fix incorrect handling of PyObject_RichCompareBool() in _zoneinfo (GH-24450)
effaec0
serhiy-storchaka commentedon Feb 5, 2021
New changeset c8b4375 by Miss Islington (bot) in branch '3.9':
bpo-43132: Fix incorrect handling of PyObject_RichCompareBool() in _zoneinfo (GH-24450) (GH-24457)
c8b4375
pganssle commentedon Feb 5, 2021
Re-opening because this was merged without tests.
@ZackerySpytz would you mind adding tests to hit these error cases? I've spent some time satisfying myself that it's indeed possible, and I've detailed a general outline here: #24450 (comment)
15 remaining items
gh-87298: Add tests for find_in_strong_cache() bug in _zoneinfo (GH-2…
pythongh-87298: Add tests for find_in_strong_cache() bug in _zoneinfo (…
pythongh-87298: Add tests for find_in_strong_cache() bug in _zoneinfo (…
[3.13] gh-87298: Add tests for find_in_strong_cache() bug in _zoneinfo (
[3.14] gh-87298: Add tests for find_in_strong_cache() bug in _zoneinfo (
pythongh-87298: Add tests for find_in_strong_cache() bug in _zoneinfo (…
pythongh-87298: Add tests for find_in_strong_cache() bug in _zoneinfo (…
pythongh-87298: Add tests for find_in_strong_cache() bug in _zoneinfo (…
pythongh-87298: Add tests for find_in_strong_cache() bug in _zoneinfo (…
pythongh-87298: Add tests for find_in_strong_cache() bug in _zoneinfo (…