Repository navigation
better name for re.error Exception class. #83162
Description
| BPO | 38981 |
|---|---|
| Nosy | @gpshead, @ezio-melotti, @serhiy-storchaka, @Carreau, @Sourabh025 |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2019-12-05.16:56:07.880>
labels = ['expert-regex', 'easy', 'type-feature', '3.9']
title = 'better name for re.error Exception class.'
updated_at = <Date 2020-09-18.07:39:36.123>
user = 'https://github.com/Carreau'bugs.python.org fields:
activity = <Date 2020-09-18.07:39:36.123>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Regular Expressions']
creation = <Date 2019-12-05.16:56:07.880>
creator = 'mbussonn'
dependencies = []
files = []
hgrepos = []
issue_num = 38981
keywords = ['patch', 'easy']
message_count = 11.0
messages = ['357867', '357878', '357882', '357883', '357884', '357886', '357962', '357982', '357986', '358059', '358124']
nosy_count = 6.0
nosy_names = ['gregory.p.smith', 'ezio.melotti', 'mrabarnett', 'serhiy.storchaka', 'mbussonn', 'sourabh025']
pr_nums = ['17501']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue38981'
versions = ['Python 3.9']
Activity
Carreau commentedon Dec 5, 2019
better error/exception name for re.compile error.
Currently the error raise by re.compile when it fails to compile is
errordefined in sre_constants.py:This is quite disturbing as most exception start with an uppercase and have a tiny bit more descriptive name.
Would it be possible to have it renamed as something more explicit like
ReCompileError, and still keeping the potentialerroralias as deprecated ?serhiy-storchaka commentedon Dec 5, 2019
It is common practice that the module specific exception is called just "error". There is nothing wrong with this.
I do not see a need to introduce a different alias.
serhiy-storchaka commentedon Dec 5, 2019
See also the discussion about renaming json.loads(): https://mail.python.org/archives/list/python-ideas@python.org/thread/EJTIVQ2ZFSVHALTLRGFCOMOYGZYMKGQU/
Carreau commentedon Dec 5, 2019
Most of the module specific classes are
Error, noterror, at least with an uppercase E you know it's a class.It will be relatively tough or them to figure out that
erroris the type of the exception.Also it's not because something works that you can't improve it ...
serhiy-storchaka commentedon Dec 5, 2019
Since it affects more than one module I suggest to discuss the idea about renaming exceptions of the Python-Ideas maillist first. Until different decision be made I am closing. Personally I think this is a duplicate of just discussed and rejected idea.
Carreau commentedon Dec 5, 2019
Thanks for the advice I've done that !
Have a good day.
serhiy-storchaka commentedon Dec 7, 2019
Reopened after discussing on Python-ideas: https://mail.python.org/archives/list/python-ideas@python.org/thread/64NHNY6RD4HQWBSBV6J7XIN7UAHNTQBR/.
32 remaining items
Merge remote-tracking branch 'upstream/main' into pythonGH-83162
pythonGH-83162: Resolved merge conflicts.
Merge remote-tracking branch 'upstream/main' into pythonGH-83162
pythonGH-83162: Satisfy merge conflict.
pythonGH-83162: Unwrap paragraph.
pythonGH-83162: Add space back in.
GH-83162: Rename re.error for better clarity. (#101677)
terryjreedy commentedon Dec 12, 2023
I merged the near-minimal PR with re.error 'updated' only in idlelib. I will do adjusted backports of the idlelib changes to keep the main bodies of its files in sync and then close.
[3.12] pythongh-83162: Rename re.error in idlelib (python#101677)
[3.12] gh-83162: Rename re.error in idlelib (GH-101677) (#112987)
[3.12] pythongh-83162: Rename re.error in idlelib (pythonGH-101677) (p…
[3.11] [3.12] gh-83162: Rename re.error in idlelib (GH-101677) (GH-11…
pythonGH-83162: Rename re.error for better clarity. (python#101677)
pythonGH-83162: Rename re.error for better clarity. (python#101677)