Repository navigation
Use FindFirstFile in ntpath.realpath() when access is denied #82367
Description
| BPO | 38186 |
|---|---|
| Nosy | @pfmoore, @tjguk, @zware, @eryksun, @zooba |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2019-09-16.12:53:56.807>
labels = ['3.8', '3.9', 'OS-windows']
title = 'Use FindFirstFile in ntpath.realpath() when access is denied'
updated_at = <Date 2019-09-16.12:56:41.984>
user = 'https://github.com/zooba'bugs.python.org fields:
activity = <Date 2019-09-16.12:56:41.984>
actor = 'steve.dower'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Windows']
creation = <Date 2019-09-16.12:53:56.807>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 38186
keywords = []
message_count = 2.0
messages = ['352543', '352544']
nosy_count = 5.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'eryksun', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue38186'
versions = ['Python 3.8', 'Python 3.9']
Activity
zooba commentedon Sep 16, 2019
There remains a case in ntpath.realpath() where a (handled) ERROR_ACCESS_DENIED or ERROR_SHARING_VIOLATION will break out of traversing a series of paths.
However, in this case (in os.stat(), for example), we could request the real name of the file from the directory using FindFirstFileW. This would correct the case and remove any path shortening (e.g. LONGFI~1 to LongFilename) without needing to directly access the file.
zooba commentedon Sep 16, 2019
See bpo-38081 and PR 16156 for related discussion and changes.
Merge branch 'python:main' into pythongh-82367-use-findfirstfile-in-n…
pythongh-82367: Use `FindFirstFile` Win32 API in `ntpath.realpath()` (p…
pythongh-82367: Use `FindFirstFile` Win32 API in `ntpath.realpath()` (p…
pythongh-82367: Use `FindFirstFile` Win32 API in `ntpath.realpath()` (p…
gh-82367: Use `FindFirstFile` Win32 API in `ntpath.realpath()` (GH-11…
zware commentedon Oct 5, 2023
Completed by @moonsikpark in GH-110298. Thanks, Moonsik!
pythongh-82367: Use `FindFirstFile` Win32 API in `ntpath.realpath()` (p…