Repository navigation
Compression level for zipfile #65616
Description
| BPO | 21417 |
|---|---|
| Nosy | @gpshead, @berkerpeksag, @serhiy-storchaka, @AraHaan, @bbayles |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2018-01-30.06:52:14.039>
created_at = <Date 2014-05-02.18:00:16.328>
labels = ['3.7', 'type-feature', 'library']
title = 'Compression level for zipfile'
updated_at = <Date 2018-02-26.22:50:36.558>
user = 'https://bugs.python.org/Sworddragon'bugs.python.org fields:
activity = <Date 2018-02-26.22:50:36.558>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2018-01-30.06:52:14.039>
closer = 'gregory.p.smith'
components = ['Library (Lib)']
creation = <Date 2014-05-02.18:00:16.328>
creator = 'Sworddragon'
dependencies = []
files = []
hgrepos = []
issue_num = 21417
keywords = ['patch']
message_count = 10.0
messages = ['217770', '245753', '272610', '272611', '272646', '311237', '312883', '312921', '312961', '312968']
nosy_count = 10.0
nosy_names = ['gregory.p.smith', 'alanmcintyre', 'Sworddragon', 'fberger', 'berker.peksag', 'jens', 'serhiy.storchaka', 'jfoo', 'Decorater', 'bbayles']
pr_nums = ['5385']
priority = 'normal'
resolution = 'fixed'
stage = 'commit review'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21417'
versions = ['Python 3.7']
Activity
Sworddragon commentedon May 2, 2014
This is a fork from this ticket: http://bugs.python.org/issue21404
tarfile has a compression level and seems to get now the missing documentation for it. But there is still a compression level missing for zipfile.
jens commentedon Jun 24, 2015
btw. hacked work-a-round is:
jfoo commentedon Aug 13, 2016
Would compresslevel be a suitable argument? All the backend compressors accept values from 1 to 9 if I'm not mistaken.
AraHaan commentedon Aug 13, 2016
Yes, it would make sence or better yet have a arg that is optional that if not set make it =
9.jfoo commentedon Aug 14, 2016
I thought about that, but:
gpshead commentedon Jan 30, 2018
New changeset ce237c7 by Gregory P. Smith (Bo Bayles) in branch 'master':
bpo-21417: Add compresslevel= to the zipfile module (GH-5385)
ce237c7
serhiy-storchaka commentedon Feb 26, 2018
I have a concern about the _compresslevel attribute of ZipInfo. Why is it underscored and not documented?
bbayles commentedon Feb 26, 2018
I made a comment about that in the pull request that went unchallenged ([1]), but I'm happy to change it.
[1] #5385 (review)
gpshead commentedon Feb 26, 2018
keeping the conversation in one place, the code review comment was: "I've prefixed this with an underscore because it's not exposed when reading back. ZipInfo has another "private" attribute, _raw_time"
compresslevel is documented on the public APIs where it appears, I do not believe it needs to be a public attribute within ZipInfo given the above as that is an implementation detail. If we ever find a good reason to make it public in the future we can add a property.
serhiy-storchaka commentedon Feb 26, 2018
This makes sense to me. Thank you for explanation.
zborro commentedon Nov 4, 2022
@gpshead so is it a bug or a feature that adding files to archive using
ZipInfocompletely ignores what compression type and compression level is set in theZipFileinstance?In the library code there is:
So it takes
ZipInfoas is. If one wants to set compression level, that private field needs to be set:Or am I missing something here?
Fix missing compression of wheels
Fix wheels not being compressed
Fix wheels not being compressed
BUG: Fix wheels not being compressed
lazka commentedon Oct 21, 2023
@zborro Because I just had a similar issue. You don't need to set the private field, you can pass compresslevel to writestr() instead:
zip_file.writestr(zip_info, compress_type=ZIP_DEFLATED, compresslevel=9)