Skip to content

Argument Clinic rollup fixes #64413

Closed
Closed

Description

@larryhastings
BPO 20214
Nosy @birkenfeld, @larryhastings
Files
  • larry.argument.clinic.misc.fixes.patch.1.txt
  • larry.argument.clinic.misc.fixes.patch.2.txt
  • larry.argument.clinic.misc.fixes.patch.3.txt
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/larryhastings'
    closed_at = <Date 2014-01-13.22:02:55.872>
    created_at = <Date 2014-01-10.01:25:38.103>
    labels = ['type-bug']
    title = 'Argument Clinic rollup fixes'
    updated_at = <Date 2014-01-13.22:02:55.871>
    user = 'https://github.com/larryhastings'

    bugs.python.org fields:

    activity = <Date 2014-01-13.22:02:55.871>
    actor = 'larry'
    assignee = 'larry'
    closed = True
    closed_date = <Date 2014-01-13.22:02:55.872>
    closer = 'larry'
    components = []
    creation = <Date 2014-01-10.01:25:38.103>
    creator = 'larry'
    dependencies = []
    files = ['33396', '33430', '33432']
    hgrepos = []
    issue_num = 20214
    keywords = []
    message_count = 6.0
    messages = ['207811', '207961', '207965', '207967', '207977', '207978']
    nosy_count = 3.0
    nosy_names = ['georg.brandl', 'larry', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue20214'
    versions = ['Python 3.4']

    Activity

    1. larryhastings commented on Jan 10, 2014

      @larryhastings
      ContributorAuthor

      Miscellaneous Argument Clinic fixes:

      • Added default value type verification for almost all return converters.
      • Added return converters for float, dobule, unsigned long,
        unsigned int, short, and unsigned short.
      • Py_buffer converter improvements:
        • Now allow exactly one value as a default value: None.
        • The default value in C only needs two fields initialized.
        • The cleanup call to PyBuffer_Release should be based on
          ".obj", not ".buf".
          As well as a bunch of documentation fixes.

      I'd love a review, but I'm pretty confident it's all okay so I may just check it in. (The only code changes are in clinic.py so it's not going to break the world.)

    2. larryhastings commented on Jan 12, 2014

      @larryhastings
      ContributorAuthor

      Freshened patch,

    3. larryhastings commented on Jan 12, 2014

      @larryhastings
      ContributorAuthor

      Also adding the one-byte fix from bpo-20201 to the rollup patch here. (Not bothering to upload a fresh patch because it is literally one byte, fixing a misspelled variable name.)

    4. larryhastings commented on Jan 12, 2014

      @larryhastings
      ContributorAuthor

      I goofed, I do have some additional fixes. Here's everything.

      Changes since patch #1:

      • Added 'converter' argument to 'object' converter.
      • Fixed misspelled variable name (see bpo-20201).
      • Several documentation updates.
    5. larryhastings commented on Jan 12, 2014

      @larryhastings
      ContributorAuthor

      Third patch, with these new features:

      • Relaxed rules regarding c_default and py_default; they can now be
        used even when no default value is supplied.
      • Added bool return converter.
      • Made one fail() call easier to read, through the power of str.format().
      • More doc updates and fixes.
    6. python-dev commented on Jan 12, 2014

      python-devmannequin
      Mannequin

      New changeset 3eee3967d03f by Larry Hastings in branch 'default':
      Issue bpo-20214: Fixed a number of small issues and documentation errors in
      http://hg.python.org/cpython/rev/3eee3967d03f

    7. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    Labels

    type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions