Repository navigation
Derby #14: Convert 41 sites to Argument Clinic across 5 files #64382
Description
| BPO | 20183 |
|---|---|
| Nosy | @larryhastings, @serhiy-storchaka, @ZackerySpytz |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2014-01-08.00:18:09.883>
labels = ['extension-modules', 'type-feature', 'expert-argument-clinic', '3.9']
title = 'Derby #14: Convert 41 sites to Argument Clinic across 5 files'
updated_at = <Date 2020-07-15.09:07:54.126>
user = 'https://github.com/larryhastings'bugs.python.org fields:
activity = <Date 2020-07-15.09:07:54.126>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules', 'Argument Clinic']
creation = <Date 2014-01-08.00:18:09.883>
creator = 'larry'
dependencies = []
files = []
hgrepos = []
issue_num = 20183
keywords = ['patch']
message_count = 7.0
messages = ['207640', '207651', '207653', '224764', '345984', '346003', '373673']
nosy_count = 3.0
nosy_names = ['larry', 'serhiy.storchaka', 'ZackerySpytz']
pr_nums = ['14201', '14207']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20183'
versions = ['Python 3.9']
Activity
larryhastings commentedon Jan 8, 2014
This issue is part of the Great Argument Clinic Conversion Derby,
where we're trying to convert as much of Python 3.4 to use
Argument Clinic as we can before Release Candidate 1 on January 19.
This issue asks you to change the following bundle of files:
Modules/mmapmodule.c: 10 sites
Modules/_localemodule.c: 10 sites
Modules/zipimport.c: 9 sites
Modules/ossaudiodev.c: 9 sites
Modules/_testbuffer.c: 9 sites
Modules/_struct.c: 3 sites
Talk to me (larry) if you only want to attack part of a bundle.
For instructions on how to convert a function to work with Argument
Clinic, read the "howto":
http://docs.python.org/dev/howto/clinic.html
skrah commentedon Jan 8, 2014
Could you take out _testbuffer.c? It has 100% coverage patches which
would break and it is not a public module.
larryhastings commentedon Jan 8, 2014
Sure. Whoever takes ownership of this issue: please ignore _testbuffer.c.
[-]Derby #14: Convert 50 sites to Argument Clinic across 6 files[/-][+]Derby #14: Convert 41 sites to Argument Clinic across 5 files[/+]larryhastings commentedon Aug 4, 2014
All the Derby patches should only go into trunk at this point.
ZackerySpytz commentedon Jun 18, 2019
PR 14201 converts Modules/_localemodule.c.
ZackerySpytz commentedon Jun 18, 2019
PR 14207 converts Modules/mmapmodule.c.
serhiy-storchaka commentedon Jul 15, 2020
New changeset bbceef6 by Zackery Spytz in branch 'master':
bpo-20183: Convert _locale to the Argument Clinic (GH-14201)
bbceef6