Repository navigation
email.utils.parsedate() and email.utils.parsedate_tz() should return None when date cannot be parsed #60129
Description
| BPO | 15925 |
|---|---|
| Nosy | @warsaw, @birkenfeld, @bitdancer |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/birkenfeld'
closed_at = <Date 2012-09-22.15:35:54.351>
created_at = <Date 2012-09-12.00:37:45.217>
labels = ['type-bug', 'expert-email', 'release-blocker']
title = 'email.utils.parsedate() and email.utils.parsedate_tz() should return None when date cannot be parsed'
updated_at = <Date 2012-09-24.05:46:47.118>
user = 'https://bugs.python.org/Arfrever'bugs.python.org fields:
activity = <Date 2012-09-24.05:46:47.118>
actor = 'python-dev'
assignee = 'georg.brandl'
closed = True
closed_date = <Date 2012-09-22.15:35:54.351>
closer = 'georg.brandl'
components = ['email']
creation = <Date 2012-09-12.00:37:45.217>
creator = 'Arfrever'
dependencies = []
files = ['27205']
hgrepos = []
issue_num = 15925
keywords = ['patch', '3.3regression']
message_count = 9.0
messages = ['170347', '170556', '170557', '170558', '170626', '170996', '170997', '171002', '171096']
nosy_count = 5.0
nosy_names = ['barry', 'georg.brandl', 'Arfrever', 'r.david.murray', 'python-dev']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue15925'
versions = ['Python 3.3']
Activity
Arfrever commentedon Sep 12, 2012
Documentation (in Python 3.3) says that None is returned when date cannot be parsed.
In Python 3.2:
In Python 3.3:
bitdancer commentedon Sep 16, 2012
Here is a patch.
Georg, this unfortunately represents a regression from 3.2 and should be fixed.
bitdancer commentedon Sep 16, 2012
Hmm. Not sure why Georg didn't get auto-added.
bitdancer commentedon Sep 16, 2012
Oh, and I'm purposely allowing parsedate_to_datetime throw exceptions. I suppose that should be documented, but that's a separate issue.
[-]email.utils.parsedate(), email.utils.parsedate_tz() and email.utils.parsedate_to_datetime() should return None when date cannot be parsed[/-][+]email.utils.parsedate() and email.utils.parsedate_tz() should return None when date cannot be parsed[/+]Arfrever commentedon Sep 17, 2012
I think that email.utils.parsedate_to_datetime("0") should raise ValueError instead of TypeError.
python-dev commentedon Sep 22, 2012
New changeset 3b03d31f6a79 by R David Murray in branch 'default':
bpo-15925: fix regression: return None for null and non-date strings.
http://hg.python.org/cpython/rev/3b03d31f6a79
bitdancer commentedon Sep 22, 2012
I don't think it is worth the extra code to convert the TypeError into a ValueError. We aren't very strict about the distinction between those two.
Leaving this open for Georg to transplant it to 3.3.0.
birkenfeld commentedon Sep 22, 2012
This was committed to the release clone as c1e9a1fc6931.
python-dev commentedon Sep 24, 2012
New changeset c1e9a1fc6931 by Georg Brandl in branch 'default':
Closes bpo-15925: fix regression in parsedate() and parsedate_tz() that should return None if unable to parse the argument.
http://hg.python.org/cpython/rev/c1e9a1fc6931