Skip to content

PEP 384 Refactoring applied to _csv module #59140

Closed
Closed
PEP 384 Refactoring applied to _csv module#59140
Labels
3.10 (EOL)end of lifeextension-modulesC modules in the Modules dirtype-featureA feature request or enhancement

Description

@RobinSchreiber
RobinSchreiber
mannequin
opened on May 28, 2012
BPO 14935
Nosy @loewis, @encukou
PRs
  • bpo-14935: Remove static state from the _csv module #23224
    		•
    Files
  • csv_pep384.patch
  • csv_pep384_v1.patch
  • csv_pep384_v2.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-12-15.15:29:01.704>
created_at = <Date 2012-05-28.16:22:51.077>
labels = ['extension-modules', 'type-feature', '3.10']
title = 'PEP 384 Refactoring applied to _csv module'
updated_at = <Date 2020-12-15.20:00:17.362>
user = 'https://bugs.python.org/RobinSchreiber'

    bugs.python.org fields:

    activity = <Date 2020-12-15.20:00:17.362>
actor = 'terry.reedy'
assignee = 'none'
closed = True
closed_date = <Date 2020-12-15.15:29:01.704>
closer = 'petr.viktorin'
components = ['Extension Modules']
creation = <Date 2012-05-28.16:22:51.077>
creator = 'Robin.Schreiber'
dependencies = []
files = ['25745', '26381', '26797']
hgrepos = []
issue_num = 14935
keywords = ['patch']
message_count = 6.0
messages = ['161791', '161792', '165451', '168181', '383060', '383068']
nosy_count = 3.0
nosy_names = ['loewis', 'petr.viktorin', 'Robin.Schreiber']
pr_nums = ['23224']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue14935'
versions = ['Python 3.10']

    Activity

    1. RobinSchreiber commented on May 28, 2012

      @RobinSchreiber
      RobinSchreibermannequin
      on May 28, 2012
      MannequinAuthor

      Corresponding to my previous Issue bpo-14732 I have now applied the Heap-Type Refactoring from PEP-341 to the _csv module. As I will apply this refactoring for almost every Standard Module, I will bundle my PEP-3121 and PEP-341 refactorings into a single patch for future releases. (In case there are no objections)

    2. RobinSchreiber
      added
      extension-modulesC modules in the Modules dir
      type-featureA feature request or enhancement
      on May 28, 2012

    3. RobinSchreiber commented on May 28, 2012

      @RobinSchreiber
      RobinSchreibermannequin
      on May 28, 2012
      MannequinAuthor

      I was of course referring to PEP-384. Sorry for the inconvenience.

    4. RobinSchreiber
      changed the title [-]PEP 341 Refactoring applied to _csv module[/-] [+]PEP 384 Refactoring applied to _csv module[/+] on May 28, 2012

    5. RobinSchreiber commented on Jul 14, 2012

      @RobinSchreiber
      RobinSchreibermannequin
      on Jul 14, 2012
      MannequinAuthor

      Added missing INCREF and DECREF inside the dealloc, and new methods of the types.

    6. RobinSchreiber commented on Aug 14, 2012

      @RobinSchreiber
      RobinSchreibermannequin
      on Aug 14, 2012
      MannequinAuthor

      Fixed the dealloc-methods of the types, for proper type dereferencing.

    7. encukou commented on Dec 15, 2020

      @encukou
      encukou
      on Dec 15, 2020
      Member

      New changeset 6a02b38 by Petr Viktorin in branch 'master':
      bpo-14935: Remove static state from the _csv module (GH-23224)
      6a02b38

    8. encukou commented on Dec 15, 2020

      @encukou
      encukou
      on Dec 15, 2020
      Member

      Thank you for working on this!
      It took several years and some new C-API to get it right (see PEP-630), but I believe this and the related issues bpo-18710 and bpo-34533 can now be closed.

    9. encukou
      closed this as completedon Dec 15, 2020
    10. terryjreedy
      added
      3.10 (EOL)end of life
      on Dec 15, 2020
    11. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.10 (EOL)end of lifeextension-modulesC modules in the Modules dirtype-featureA feature request or enhancement

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions