Repository navigation
intern_static() never detects a failed _Py_hashtable_set() (< -1 should be < 0) #157892
Description
Bug report
Bug description:
In intern_static() in Objects/unicodeobject.c, the result of _Py_hashtable_set() is compared with < -1:
cpython/Objects/unicodeobject.c
Line 14591 in 21223c9
_Py_hashtable_set() (Python/hashtable.c) returns 0 on success and -1 when the entry allocation fails, so this condition is never true and the Py_FatalError() call is unreachable.
The check has been like this since gh-120520, so 3.13, 3.14 and main are affected.
CPython versions tested on:
CPython main branch
Operating systems tested on:
No response
Linked PRs
- gh-157892: Fix error check on _Py_hashtable_set() in intern_static() #157898
- [3.13] gh-157892: Fix error check on _Py_hashtable_set() in intern_static() (GH-157898) #158299
- [3.14] gh-157892: Fix error check on _Py_hashtable_set() in intern_static() (GH-157898) #158300
- [3.15] gh-157892: Fix error check on _Py_hashtable_set() in intern_static() (GH-157898) #158301
Activity
Vara715 commentedon Sep 27, 2026
hey, can i work on this one?
pochmann commentedon Sep 27, 2026
@Vara715 Why? What's wrong with the already existing PR? What would you do differently?
gh-157892: Fix error check on _Py_hashtable_set() in intern_static() (#…
[3.13] gh-157892: Fix error check on _Py_hashtable_set() in intern_st…
[3.14] gh-157892: Fix error check on _Py_hashtable_set() in intern_st…
[3.15] gh-157892: Fix error check on _Py_hashtable_set() in intern_st…