Skip to content

_zstd: Fix printf format for pledged size errors #146578

Closed
Closed
_zstd: Fix printf format for pledged size errors#146578
Labels
3.14bugs and security fixes3.15bugs and security fixesextension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

Description

@cuiweixie
cuiweixie
opened on Mar 28, 2026

Problem

In zstd_contentsize_converter (Modules/_zstd/compressor.c), ValueError messages use the format specifier %ull when printing ZSTD_CONTENTSIZE_ERROR. The correct C99 format for unsigned long long is %llu; %ull is invalid.

Proposed fix

Replace %ull with %llu in both error paths.

Linked PRs

Activity

  1. cuiweixie commented on Mar 28, 2026

    @cuiweixie
    cuiweixie
    on Mar 28, 2026
    ContributorAuthor

    PR: #146576

  2. brianschubert
    added
    type-bugAn unexpected behavior, bug, or error
    extension-modulesC modules in the Modules dir
    3.14bugs and security fixes
    3.15bugs and security fixes
    on Mar 28, 2026

  3. brianschubert commented on Mar 28, 2026

    @brianschubert
    brianschubert
    on Mar 28, 2026
    Contributor

    I can confirm that the exception message is currently formatted incorrectly (note the trailing ll):

    >>> compression.zstd.ZstdCompressor().set_pledged_input_size(2**64)
Traceback (most recent call last):
  File "<python-input-1>", line 1, in <module>
    compression.zstd.ZstdCompressor().set_pledged_input_size(2**64)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^
ValueError: size argument should be a positive int less than 4294967294ll
  4. StanFromIreland
    added this to Compression issues 🗜on Mar 28, 2026
  5. emmatyping
    added 2 commits that reference this issue on Apr 21, 2026

    gh-146578: _zstd: Fix printf format for pledged size errors (#146576)

    09233bd

    [3.14] gh-146578: _zstd: Fix printf format for pledged size errors (G…

    5aa8234
  6. emmatyping
    closed this as completedon Apr 21, 2026
  7. github-project-automation
    moved this to Done in Compression issues 🗜on Apr 21, 2026
  8. ljfp
    added a commit that references this issue on Apr 25, 2026

    pythongh-146578: _zstd: Fix printf format for pledged size errors (py…

    de7a251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.14bugs and security fixes3.15bugs and security fixesextension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions