Skip to content

Prevent make venv from saying it succeeded when it failed #136854

Closed
#136856
Closed
Prevent make venv from saying it succeeded when it failed#136854
#136856
Labels
docsDocumentation in the Doc dirsprint

Description

@nachocab
nachocab
opened on Jul 20, 2025

As reported in python/devguide#1607, if an error happens when executing make venv, it will still be reported as successful ("The venv has been created in the ./venv directory").

The set -e option should be enabled to exit on error.

Linked PRs

Activity

  1. nachocab
    added
    docsDocumentation in the Doc dir
    on Jul 20, 2025
  2. github-project-automation
    added this to docs issueson Jul 20, 2025
  3. github-project-automation
    moved this to Todo in docs issueson Jul 20, 2025
  4. hugovk
    added
    sprint
    on Jul 20, 2025
  5. ezio-melotti
    added this to Sprinton Jul 20, 2025
  6. github-project-automation
    moved this to Todo in Sprinton Jul 20, 2025
  7. hugovk
    closed this as completedin #136856on Jul 20, 2025
  8. hugovk
    added a commit that references this issue on Jul 20, 2025

    gh-136854: Exit on error in `make venv` (#136856)

    9c2f91c
  9. github-project-automation
    moved this from Todo to Done in Sprinton Jul 20, 2025
  10. miss-islington
    added 2 commits that reference this issue on Jul 20, 2025

    pythongh-136854: Exit on error in `make venv` (pythonGH-136856)

    dad1dc5

    pythongh-136854: Exit on error in `make venv` (pythonGH-136856)

    68b645b
  11. hugovk
    added 2 commits that reference this issue on Jul 20, 2025

    [3.14] gh-136854: Exit on error in `make venv` (GH-136856) (#136860)

    ee37365

    [3.13] gh-136854: Exit on error in `make venv` (GH-136856) (#136861)

    1172f4c
  12. picnixz
    added a commit that references this issue on Jul 20, 2025

    pythongh-136854: Exit on error in `make venv` (python#136856)

    33ac314
  13. taegyunkim
    added a commit that references this issue on Aug 4, 2025

    pythongh-136854: Exit on error in `make venv` (python#136856)

    15f51e6
  14. Agent-Hellboy
    added a commit that references this issue on Aug 19, 2025

    pythongh-136854: Exit on error in `make venv` (python#136856)

    4127177
  15. kumaraditya303
    added a commit that references this issue on Sep 9, 2025

    [3.14] pythongh-136854: Exit on error in `make venv` (pythonGH-136856) (

    acb7541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docsDocumentation in the Doc dirsprint

    Projects

    • Sprint
      Status
      Done
    • docs issues
      Status
      Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions