You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
_colorize.can_colorize safety in test_argparse #135237
In order to ensure its tests are meaningful even if color is disabled, the TestColorized test object in test_argparse modifies _colorize.can_colorize during setup, but does not subsequently restore it to the original value. As a consequence, the rest of the test session is polluted with colors/color codes even if NO_COLOR=1, or when in a dumb terminal or pipe. By comparison, we can look at the output of a similar setup in test_regrtest that uses mock.patch to only affect the state in that one test.
Given:
export NO_COLOR=1
Expected:
./python -m test test_regrtest -m TestColorized
Polluted visuals:
./python -m test test_argparse test_regrtest -m TestColorized
Polluted text:
./python -m test test_argparse test_regrtest -m TestColorized > OUTPUT.txt
less OUTPUT.txt
Hey there - I missed this issue. However, I ended up inadvertently fixing this as part of #139818, which was merged earlier this week. Thanks so much for filing the issue (and the corresponding PR).
Activity
savannahostrowski commentedon Oct 12, 2025
Hey there - I missed this issue. However, I ended up inadvertently fixing this as part of #139818, which was merged earlier this week. Thanks so much for filing the issue (and the corresponding PR).