Skip to content

More than thousand 'Py_DEBUG': macro redefinition warnings for Windows debug builds on 3.14 branch #134774

Closed

Description

@chris-eibl

Bug report

Bug description:

Since PR #134211 / issue #133779 was packported to 3.14, Windows debug builds show more than thousand such warnings:

pyconfig.h(390,16): warning C4005: 'Py_DEBUG': macro redefinition

For example

This stems from

cpython/PC/pyconfig.h

Lines 97 to 100 in b6e624a

/* _DEBUG implies Py_DEBUG */
#ifdef _DEBUG
# define Py_DEBUG 1
#endif

which got added in the above PR, but rather belong to PR #131944 / issue #131942, which did not get backported, and should just be deleted.

CPython versions tested on:

3.14

Operating systems tested on:

Windows

Linked PRs

Activity

  1. added
    type-bugAn unexpected behavior, bug, or error
    3.14bugs and security fixes
    on May 27, 2025
  2. chris-eibl commented on May 27, 2025

    @chris-eibl
    MemberAuthor

    @zooba: I can do a PR, but since this is 3.14 related, I assume this is one of the rare cases where the PR should not be created against main?

  3. zooba commented on May 27, 2025

    @zooba
    Member

    Yeah, probably just a bad backport. Make a PR directly against the 3.14 branch, and include [3.14] at the start of the title to satisfy the backport checker.

  4. changed the title [-][3.14] More than thousand 'Py_DEBUG': macro redefinition warnings for Windows debug builds on 3.14 branch[/-] [+]More than thousand 'Py_DEBUG': macro redefinition warnings for Windows debug builds on 3.14 branch[/+] on May 27, 2025
  5. added a commit that references this issue on May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.14bugs and security fixesOS-windowsbuildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions