Skip to content

Missing error handling in SET_COUNT macro in _testinternalcapi.c #133891

Closed
Closed
Missing error handling in SET_COUNT macro in _testinternalcapi.c#133891
Assignees
sobolevn
Labels
3.14bugs and security fixes3.15bugs and security fixesextension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

Description

@sobolevn
sobolevn
opened on May 11, 2025

Bug report

Refs #133265

Right here PyLong_FromLong can in theory (unlikely in practice) return NULL. It is missing this check. I understand that this is a test code, but I also don't see a reason why we should not be explicit about it.

cpython/Modules/_testinternalcapi.c

Line 1045 in 13cb8ca

#define SET_COUNT(DICT, STRUCT, NAME) \

cc @ericsnowcurrently

I have a PR ready.

Linked PRs

Activity

  1. sobolevn
    self-assigned this
    on May 11, 2025
  2. sobolevn
    added
    type-bugAn unexpected behavior, bug, or error
    extension-modulesC modules in the Modules dir
    on May 11, 2025
  3. sobolevn
    added a commit that references this issue on May 11, 2025

    pythongh-133891: Add missing error check to `SET_COUNT` macro in `_te…

    69b8adf
  4. sobolevn
    changed the title [-]Missing error handling in[/-] [+]Missing error handling in `SET_COUNT` macro in `_testinternalcapi.c`[/+] on May 11, 2025
  5. sobolevn
    added a commit that references this issue on May 31, 2025

    gh-133891: Add missing error check to `SET_COUNT` macro in `_testinte…

    cebae97
  6. miss-islington
    added a commit that references this issue on May 31, 2025

    pythongh-133891: Add missing error check to `SET_COUNT` macro in `_te…

    7bd50e1
  7. sobolevn
    added a commit that references this issue on May 31, 2025

    [3.14] gh-133891: Add missing error check to `SET_COUNT` macro in `_t…

    a8708f7
  8. sobolevn
    closed this as completedon May 31, 2025
  9. picnixz
    added
    3.14bugs and security fixes
    3.15bugs and security fixes
    on May 31, 2025
  10. Pranjal095
    added a commit that references this issue on Jul 12, 2025

    pythongh-133891: Add missing error check to `SET_COUNT` macro in `_te…

    a3dd22b
  11. taegyunkim
    added a commit that references this issue on Aug 4, 2025

    pythongh-133891: Add missing error check to `SET_COUNT` macro in `_te…

    7d848b2
  12. Agent-Hellboy
    added a commit that references this issue on Aug 19, 2025

    pythongh-133891: Add missing error check to `SET_COUNT` macro in `_te…

    cb2bde8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

3.14bugs and security fixes3.15bugs and security fixesextension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions