Skip to content

Add typing to more build tools #133403

Closed
Closed
Add typing to more build tools#133403
Assignees
sobolevnFlosckow
Labels
infraCI, GitHub Actions, buildbots, Dependabot, etc.type-featureA feature request or enhancement

Description

@sobolevn
sobolevn
opened on May 4, 2025

Feature or enhancement

Right now we support typing in several build tools:

cpython/Tools/build/mypy.ini

Lines 2 to 4 in 6ce60f1

files =
Tools/build/compute-changes.py,
Tools/build/generate_sbom.py

I think that some other files / tools from this folder can benefit from being checked with mypy.

I have a PR ready for Tools/build/update_file.py of parser.c generation.
What else can be easily typed?

Linked PRs

Activity

  1. sobolevn
    added
    infraCI, GitHub Actions, buildbots, Dependabot, etc.
    type-featureA feature request or enhancement
    on May 4, 2025
  2. sobolevn
    self-assigned this
    on May 4, 2025
  3. sobolevn
    added 4 commits that reference this issue on May 4, 2025

    pythongh-133403: Type `Tools/build/update_file.py` and check it with …

    9b37430

    pythongh-133403: Type `Tools/build/update_file.py` and check it with …

    acc0ebe

    pythongh-133403: Type `Tools/build/update_file.py` and check it with …

    63668b0

    pythongh-133403: Type `Tools/build/update_file.py` and check it with …

    7c10f27

  4. sobolevn commented on May 4, 2025

    @sobolevn
    sobolevn
    on May 4, 2025
    MemberAuthor

    Tools/build/verify_ensurepip_wheels.py also has annotations, but it is not checked. Will add in a separate PR, since it requires a bit of modification:

    Tools/build/verify_ensurepip_wheels.py:41: error: Argument 1 to "print_error" has
incompatible type "Path"; expected "str"  [arg-type]
                    print_error(p, f"Found more than one wheel for package {package_n...
                                ^
Tools/build/verify_ensurepip_wheels.py:56: error: Argument 1 to "print_error" has
incompatible type "Path"; expected "str"  [arg-type]
                package_path,
                ^~~~~~~~~~~~
Tools/build/verify_ensurepip_wheels.py:66: error: Argument 1 to "print_error" has
incompatible type "Path"; expected "str"  [arg-type]
            print_error(package_path, f"Could not fetch JSON metadata for {package_na...
                        ^~~~~~~~~~~~
Tools/build/verify_ensurepip_wheels.py:76: error: Argument 1 to "print_error" has
incompatible type "Path"; expected "str"  [arg-type]
            print_error(package_path, f"No digest for {package_name} found from PyPI....
                        ^~~~~~~~~~~~
Tools/build/verify_ensurepip_wheels.py:82: error: Name "expected_digest" may be undefined 
[possibly-undefined]
        print(f"Expected digest: {expected_digest}")
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Tools/build/verify_ensurepip_wheels.py:87: error: Argument 1 to "print_error" has
incompatible type "Path"; expected "str"  [arg-type]
                package_path, f"Failed to verify the checksum of the {package_name} w...
                ^~~~~~~~~~~~
Tools/build/verify_ensurepip_wheels.py:92: error: Argument 1 to "print_notice" has
incompatible type "Path"; expected "str"  [arg-type]
            package_path,
            ^~~~~~~~~~~~
Found 7 errors in 1 file (checked 4 source files)

  5. sobolevn commented on May 4, 2025

    @sobolevn
    sobolevn
    on May 4, 2025
    MemberAuthor

    We should also merge #133405 before any other PR.

  6. Flosckow commented on May 5, 2025

    @Flosckow
    Flosckow
    on May 5, 2025
    Contributor

    Can I work on it?

  7. sobolevn commented on May 5, 2025

    @sobolevn
    sobolevn
    on May 5, 2025
    MemberAuthor

    @Flosckow sure, you can help with #133403 (comment) I haven't started yet :)

    Thank you!

  8. sobolevn
    assigned
    Flosckow
    on May 5, 2025

  9. Flosckow commented on May 5, 2025

    @Flosckow
    Flosckow
    on May 5, 2025
    Contributor

    @Flosckowконечно, вы можете помочь с #133403 (комментарий) Я еще не начал :)

    Спасибо!

    Yes, I'll try to do this, the only thing I might be a little slow is this is my first pr in cpython.

  10. sobolevn commented on May 5, 2025

    @sobolevn
    sobolevn
    on May 5, 2025
    MemberAuthor

    No worries, I can surely help with any questions you might have. Feel free to ask them :)

  11. Flosckow
    added a commit that references this issue on May 5, 2025

    pythongh-133403: Type Tools/build/verify_ensurepip_wheels.py and chec…

    1d9a5c0

  12. 51 remaining items

  13. hugovk
    added a commit that references this issue on Aug 27, 2025

    [3.14] gh-133403: Run `mypy` on `Tools/build/check_warnings.py` (GH-1…

    e3fb55e
  14. kumaraditya303
    added 3 commits that reference this issue on Sep 9, 2025

    [3.14] pythongh-133403: Check `generate_stdlib_module_names` and `che…

    8119aa3

    [3.14] pythongh-133403: Run `mypy` on `Tools/build/mypy.ini` changes (p…

    b03e53a

    [3.14] pythongh-133403: Run `mypy` on `Tools/build/check_warnings.py` (…

    5c6bddc
  15. sandole
    added 3 commits that reference this issue on Dec 31, 2025

    pythongh-133403: Add type annotations to generate_levenshtein_example…

    c5cfc29

    Add NEWS entry for pythongh-133403

    ce4462f

    pythongh-133403: Add type annotations to generate_levenshtein_example…

    22a495d

  16. RafaelWO commented on Feb 1, 2026

    @RafaelWO
    RafaelWO
    on Feb 1, 2026
    Contributor

    Hey there, I also would like to help out and add typing to more of the build scripts.

    Currently, the following script are not yet checked by mypy:

    • Tools/build/freeze_modules.py
    • Tools/build/generate_global_objects.py
    • Tools/build/generate_levenshtein_examples.py (open PR gh-133403: Add type annotations to generate_levenshtein_examples.py #143317)
    • Tools/build/generate_re_casefix.py
    • Tools/build/generate_sre_constants.py
    • Tools/build/generate_token.py
    • Tools/build/parse_html5_entities.py
    • Tools/build/smelly.py
    • Tools/build/stable_abi.py

    Are there any scripts that don't need typing? Otherwise, I would start with Tools/build/generate_re_casefix.py.

  17. picnixz commented on Feb 1, 2026

    @picnixz
    picnixz
    on Feb 1, 2026
    Member

    It depends on whether the codeowner/maintainer of those modules want such additions and whether adding them brings real value.

  18. hugovk
    added a commit that references this issue on Apr 18, 2026

    gh-133403: Add type annotations to generate_levenshtein_examples.py (#…

    28b8d5f
  19. miss-islington
    added a commit that references this issue on Apr 18, 2026

    pythongh-133403: Add type annotations to generate_levenshtein_example…

    f4718bd
  20. hugovk
    added a commit that references this issue on Apr 19, 2026

    [3.14] gh-133403: Add type annotations to generate_levenshtein_exampl…

    b0104a9
  21. ljfp
    added a commit that references this issue on Apr 25, 2026

    pythongh-133403: Add type annotations to generate_levenshtein_example…

    4eb08bb

  22. StanFromIreland commented on Aug 27, 2026

    @StanFromIreland
    StanFromIreland
    on Aug 27, 2026
    Member

    I'm closing this, let's create new issues for the remaining tools so that decisions can be made on a case-by-case basis.

  23. StanFromIreland
    closed this as completedon Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

infraCI, GitHub Actions, buildbots, Dependabot, etc.type-featureA feature request or enhancement

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions