Skip to content

Consider making staticmethod and classmethod generic #132457

Closed
Closed
Consider making staticmethod and classmethod generic#132457
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)topic-typingtype-featureA feature request or enhancement

Description

@sobolevn
sobolevn
opened on Apr 12, 2025

Feature or enhancement

Typeshed defines staticmethod and classmethod as generics:

  1. https://github.com/python/typeshed/blob/f6216ec6230aa51fe7e23afca30a8f5b18ace476/stdlib/builtins.pyi#L137
  2. https://github.com/python/typeshed/blob/f6216ec6230aa51fe7e23afca30a8f5b18ace476/stdlib/builtins.pyi#L154

It makes sense, because they are very callable-like. However:

>>> staticmethod[int]
Traceback (most recent call last):
  File "<python-input-0>", line 1, in <module>
    staticmethod[int]
    ~~~~~~~~~~~~^^^^^
TypeError: type 'staticmethod' is not subscriptable
>>> classmethod[int]
Traceback (most recent call last):
  File "<python-input-1>", line 1, in <module>
    classmethod[int]
    ~~~~~~~~~~~^^^^^
TypeError: type 'classmethod' is not subscriptable

We should consider making them generics in runtime as well.

@AlexWaygood @JelleZijlstra thoughts?
If you agree, I have a PR ready.

Linked PRs

Activity

  1. sobolevn
    added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    topic-typing
    type-featureA feature request or enhancement
    on Apr 12, 2025
  2. sobolevn
    assigned
    sobolevn
    and unassigned
    sobolevn
    on Apr 12, 2025

  3. IvanKirpichnikov commented on Apr 17, 2025

    @IvanKirpichnikov
    IvanKirpichnikov
    on Apr 17, 2025
    Contributor

    Another thing I noticed is that some generics in typeshed are not actually generics.
    For example, almost all objects in itertools.pyi and functools.pyi are generics, but only a few of them are actually generics.

    I can provide a list of such objects. I am also ready to undertake this correction if it is approved.

  4. sobolevn
    added a commit that references this issue on May 4, 2025

    gh-132457: make staticmethod and classmethod generic (#132460)

    a363675
  5. sobolevn
    closed this as completedon May 4, 2025

  6. JelleZijlstra commented on May 4, 2025

    @JelleZijlstra
    JelleZijlstra
    on May 4, 2025
    Member

    For a number of itertools there's already an open issue in CPython, there was some hesitation about making them generic at runtime.

  7. diegorusso
    added a commit that references this issue on May 4, 2025

    Merge remote-tracking branch 'origin/main' into call-len

    c03babc
  8. Pranjal095
    added a commit that references this issue on Jul 12, 2025

    pythongh-132457: make staticmethod and classmethod generic (python#13…

    318bb66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    interpreter-core(Objects, Python, Grammar, and Parser dirs)topic-typingtype-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions