Skip to content

Remove unused code related to the removed BINARY_SUBSCR instruction #131306

Closed
Closed
Remove unused code related to the removed BINARY_SUBSCR instruction#131306
Assignees
tomasr8
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancement

Description

@tomasr8
tomasr8
opened on Mar 15, 2025

BINARY_SUBSCR was replaced with BINARY_OP and the NB_SUBSCR oparg in #129700 but there is still some code related to BINARY_SUBSCR that I believe can be removed. Some examples:

cpython/Include/internal/pycore_code.h

Lines 121 to 125 in e82c2ca

typedef struct {
_Py_BackoffCounter counter;
} _PyBinarySubscrCache;
#define INLINE_CACHE_ENTRIES_BINARY_SUBSCR CACHE_ENTRIES(_PyBinarySubscrCache)

cpython/Lib/opcode.py

Lines 66 to 68 in e82c2ca

"BINARY_SUBSCR": {
"counter": 1,
},

Linked PRs

Activity

  1. tomasr8
    added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    on Mar 15, 2025
  2. tomasr8
    self-assigned this
    on Mar 15, 2025
  3. picnixz
    added
    type-featureA feature request or enhancement
    on Mar 15, 2025
  4. iritkatriel
    added a commit that references this issue on Mar 16, 2025

    gh-131306: Remove unused code related to `BINARY_SUBSCR` (#131307)

    d07e9eb
  5. tomasr8
    closed this as completedon Mar 16, 2025
  6. plashchynski
    added a commit that references this issue on Mar 17, 2025

    pythongh-131306: Remove unused code related to `BINARY_SUBSCR` (pytho…

    e2e8bb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancement

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions