Skip to content

test_pickle tests failing when invoked directly #131031

Closed
Closed
test_pickle tests failing when invoked directly#131031
Labels
testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Description

@donbarbos
donbarbos
opened on Mar 10, 2025

I ran separate tests for the pickle module on main branch:

./python ./Lib/test/test_pickle.py

I got 24 failures
Judging by the output, the problem is in the mismatch of error messages:

test_nested_lookup_error (__main__.CPicklingErrorTests.test_nested_lookup_error) ...
  test_nested_lookup_error (__main__.CPicklingErrorTests.test_nested_lookup_error) (proto=0) ... FAIL
  test_nested_lookup_error (__main__.CPicklingErrorTests.test_nested_lookup_error) (proto=1) ... FAIL
  test_nested_lookup_error (__main__.CPicklingErrorTests.test_nested_lookup_error) (proto=2) ... FAIL
  test_nested_lookup_error (__main__.CPicklingErrorTests.test_nested_lookup_error) (proto=3) ... FAIL
  test_nested_lookup_error (__main__.CPicklingErrorTests.test_nested_lookup_error) (proto=4) ... FAIL
  test_nested_lookup_error (__main__.CPicklingErrorTests.test_nested_lookup_error) (proto=5) ... FAIL
...
test_wrong_object_lookup_error (__main__.CPicklingErrorTests.test_wrong_object_lookup_error) ...
  test_wrong_object_lookup_error (__main__.CPicklingErrorTests.test_wrong_object_lookup_error) (proto=0) ... FAIL
  test_wrong_object_lookup_error (__main__.CPicklingErrorTests.test_wrong_object_lookup_error) (proto=1) ... FAIL
  test_wrong_object_lookup_error (__main__.CPicklingErrorTests.test_wrong_object_lookup_error) (proto=2) ... FAIL
  test_wrong_object_lookup_error (__main__.CPicklingErrorTests.test_wrong_object_lookup_error) (proto=3) ... FAIL
  test_wrong_object_lookup_error (__main__.CPicklingErrorTests.test_wrong_object_lookup_error) (proto=4) ... FAIL
  test_wrong_object_lookup_error (__main__.CPicklingErrorTests.test_wrong_object_lookup_error) (proto=5) ... FAIL
...
test_nested_lookup_error (__main__.PyPicklingErrorTests.test_nested_lookup_error) ...
  test_nested_lookup_error (__main__.PyPicklingErrorTests.test_nested_lookup_error) (proto=0) ... FAIL
  test_nested_lookup_error (__main__.PyPicklingErrorTests.test_nested_lookup_error) (proto=1) ... FAIL
  test_nested_lookup_error (__main__.PyPicklingErrorTests.test_nested_lookup_error) (proto=2) ... FAIL
  test_nested_lookup_error (__main__.PyPicklingErrorTests.test_nested_lookup_error) (proto=3) ... FAIL
  test_nested_lookup_error (__main__.PyPicklingErrorTests.test_nested_lookup_error) (proto=4) ... FAIL
  test_nested_lookup_error (__main__.PyPicklingErrorTests.test_nested_lookup_error) (proto=5) ... FAIL
...
test_wrong_object_lookup_error (__main__.PyPicklingErrorTests.test_wrong_object_lookup_error) ...
  test_wrong_object_lookup_error (__main__.PyPicklingErrorTests.test_wrong_object_lookup_error) (proto=0) ... FAIL
  test_wrong_object_lookup_error (__main__.PyPicklingErrorTests.test_wrong_object_lookup_error) (proto=1) ... FAIL
  test_wrong_object_lookup_error (__main__.PyPicklingErrorTests.test_wrong_object_lookup_error) (proto=2) ... FAIL
  test_wrong_object_lookup_error (__main__.PyPicklingErrorTests.test_wrong_object_lookup_error) (proto=3) ... FAIL
  test_wrong_object_lookup_error (__main__.PyPicklingErrorTests.test_wrong_object_lookup_error) (proto=4) ... FAIL
  test_wrong_object_lookup_error (__main__.PyPicklingErrorTests.test_wrong_object_lookup_error) (proto=5) ... FAIL

Examples of mismatches:

AssertionError: "type object 'AbstractPickleTests' has no attribute 'spam'" != "module '__main__' has no attribute 'AbstractPickleTests'"
- type object 'AbstractPickleTests' has no attribute 'spam'
+ module '__main__' has no attribute 'AbstractPickleTests'
...
AssertionError: "Can'[53 chars]4b0>: it's not the same object as __main__.AbstractPickleTests" != "Can'[53 chars]4b0>: it's not found as __main__.AbstractPickleTests"
- Can't pickle <test.pickletester.REX object at 0x79fcb255a4b0>: it's not the same object as __main__.AbstractPickleTests
?                                                                         ^^^^^^^^^ ^^^^^
+ Can't pickle <test.pickletester.REX object at 0x79fcb255a4b0>: it's not found as __main__.AbstractPickleTests
?

I'm going to send PR after we decide what the messages should look like

Linked PRs

Activity

  1. tomasr8
    added
    testsTests in the Lib/test dir
    on Mar 10, 2025
  2. tomasr8
    added this to Pickle and copy issues 🥒on Mar 10, 2025
  3. picnixz
    added
    type-bugAn unexpected behavior, bug, or error
    on Mar 12, 2025
  4. donbarbos
    changed the title [-]tests `test_pickle` failed due to error message mismatch[/-] [+]`test_pickle` tests failing when invoked directly[/+] on May 3, 2025
  5. serhiy-storchaka
    added a commit that references this issue on May 3, 2025

    pythongh-131031: Fix test_pickle when invoked directly

    63e7321

  6. serhiy-storchaka commented on May 3, 2025

    @serhiy-storchaka
    serhiy-storchaka
    on May 3, 2025
    Member

    Good catch @donbarbos! Thank you.

    Your PR fixes tests, but I think that it would be better to not use AbstractPickleTests in these tests. For these tests we need an existing global class which does not exist in __main__ . Running tests as a script fails because AbstractPickleTests is imported in test_pickle.py which becomes __main__. #133356 uses this approach.

  7. serhiy-storchaka
    added a commit that references this issue on May 8, 2025

    gh-131031: Fix test_pickle when invoked directly (GH-133356)

    e15bbfa
  8. miss-islington
    added a commit that references this issue on May 8, 2025

    pythongh-131031: Fix test_pickle when invoked directly (pythonGH-133356)

    c4ec2b0
  9. serhiy-storchaka
    added a commit that references this issue on May 8, 2025

    [3.13] pythongh-131031: Fix test_pickle when invoked directly (python…

    9570eae
  10. serhiy-storchaka
    closed this as completedon May 8, 2025
  11. github-project-automation
    moved this to Done in Pickle and copy issues 🥒on May 8, 2025
  12. serhiy-storchaka
    added 2 commits that reference this issue on May 8, 2025

    [3.14] gh-131031: Fix test_pickle when invoked directly (GH-133356) (G…

    dc1a4dd

    [3.13] gh-131031: Fix test_pickle when invoked directly (GH-133356) (G…

    8e334f4
  13. Pranjal095
    added a commit that references this issue on Jul 12, 2025

    pythongh-131031: Fix test_pickle when invoked directly (pythonGH-133356)

    3fad0ba
  14. taegyunkim
    added a commit that references this issue on Aug 4, 2025

    pythongh-131031: Fix test_pickle when invoked directly (pythonGH-133356)

    9326ba8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions