Repository navigation
Missing Py_CLEAR/Py_VISIT calls for Unpickler.persistent_load_attr and Pickler.persistent_id_attr #130179
Description
Bug report
Bug description:
I found that Unpickler.persistent_load_attr and Pickler.persistent_id_attr can be set, but never clear. However, I didn't find any uses of them.
Another issue, I found that PDATA_APPEND and PDATA_PUSH may lead to memory leaks if PyErr_NoMemory is raised. What do we do about resources when this happens? I've seen resources get cleared, and sometimes they don't.
CPython versions tested on:
CPython main branch
Operating systems tested on:
No response
Activity
Merge branch 'main' into pythongh-130179-pickle-memory-leaks
[-]Possible memory leaks in _pickle[/-][+]`_pickle`: Missing `Py_CLEAR/Py_VISIT` calls for `Unpickler.persistent_load_attr` and `Pickler.persistent_id_attr`[/+][-]`_pickle`: Missing `Py_CLEAR/Py_VISIT` calls for `Unpickler.persistent_load_attr` and `Pickler.persistent_id_attr`[/-][+]Missing `Py_CLEAR/Py_VISIT` calls for `Unpickler.persistent_load_attr` and `Pickler.persistent_id_attr`[/+]gh-130179: Fix `persistent_{id,load}_attr` reference leaks in `_pickl…
pythongh-130179: Fix `persistent_{id,load}_attr` reference leaks in `…
[3.13] gh-130179: Fix `persistent_{id,load}_attr` reference leaks in …