Repository navigation
LDFLAGS and LIBS not used consistently in configure #128354
Description
Bug report
Bug description:
Following up on #128322, I noticed that the same pattern of setting LDFLAGS instead of LIBS is used frequently. Additionally, there is not consistency in the ordering of the added libraries, e.g., LIBS="$LIBS ..." vs LIBS="... $LIBS".
For cases where the linking order matters, I believe using LDFLAGS is incorrect and the existing $LIBS should always come first.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Activity
gh-128354: Consistently use LIBS over LDFLAGS in library build checks (…
[3.13] pythongh-128354: Consistently use LIBS over LDFLAGS in library…
[3.12] pythongh-128354: Consistently use LIBS over LDFLAGS in library…
[3.12] gh-128354: Consistently use LIBS over LDFLAGS in library build… (
[3.13] gh-128354: Consistently use LIBS over LDFLAGS in library build… (
pythongh-128354: Consistently use LIBS over LDFLAGS in library build …
pythongh-128354: Consistently use LIBS over LDFLAGS in library build …
hugovk commentedon Jan 8, 2025
@zanieb Thanks for the PR, now merged and backported! Can we close this issue now?