You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Protocols in wsgiref.types should use @abstractmethod #127678
If it's accepted, I'm not sure this would be backportable -- it could be considered a breaking change. What if a class inherits from one of these protocols but doesn't override one of the methods you're proposing to make abstract?
That is indeed a breaking change, and probably one where there's not good deprecation path. But I also assume that the impact is rather small and would point to actual bugs. But checking the top 1000 or so packages for this would be a good idea.
Activity
AlexWaygood commentedon Dec 6, 2024
If it's accepted, I'm not sure this would be backportable -- it could be considered a breaking change. What if a class inherits from one of these protocols but doesn't override one of the methods you're proposing to make abstract?
srittau commentedon Dec 6, 2024
That is indeed a breaking change, and probably one where there's not good deprecation path. But I also assume that the impact is rather small and would point to actual bugs. But checking the top 1000 or so packages for this would be a good idea.