bytearray().__buffer__(256) crashes

@JelleZijlstra

Crash report

Code says that it cannot fail:

Lines 44 to 56 in 4cd1076

    
           static int 
        
           bytearray_getbuffer(PyObject *self, Py_buffer *view, int flags) 
        
           { 
        
               PyByteArrayObject *obj = _PyByteArray_CAST(self); 
        
               if (view == NULL) { 
        
                   PyErr_SetString(PyExc_BufferError, 
        
                       "bytearray_getbuffer: view==NULL argument is obsolete"); 
        
                   return -1; 
        
               } 
        
               void *ptr = (void *) PyByteArray_AS_STRING(obj); 
        
               /* cannot fail if view != NULL and readonly == 0 */ 
        
               (void)PyBuffer_FillInfo(view, (PyObject*)obj, ptr, Py_SIZE(obj), 0, flags);

But, it can:

cpython/Objects/abstract.c

Lines 770 to 774 in 4cd1076

    
           if (flags != PyBUF_SIMPLE) {  /* fast path */ 
        
               if (flags == PyBUF_READ || flags == PyBUF_WRITE) { 
        
                   PyErr_BadInternalCall(); 
        
                   return -1; 
        
               }

I have a PR ready.

CC @JelleZijlstra

Linked PRs

pythongh-126980: Fix `bytearray.__buffer__` crash on `PyBUF_{READ,WRI…

gh-126980: Fix `bytearray.__buffer__` crash on `PyBUF_{READ,WRITE}` (#…

[3.13] pythongh-126980: Fix `bytearray.__buffer__` crash on `PyBUF_{R…

[3.13] gh-126980: Fix `bytearray.__buffer__` crash on `PyBUF_{READ,WR…

pythongh-126980: Fix `bytearray.__buffer__` crash on `PyBUF_{READ,WRI…

Navigation Menu

Repository navigation

`bytearray().buffer(256)` crashes #126980

Crash report

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	static int
	bytearray_getbuffer(PyObject self, Py_buffer view, int flags)
	{
	PyByteArrayObject *obj = _PyByteArray_CAST(self);
	if (view == NULL) {
	PyErr_SetString(PyExc_BufferError,
	"bytearray_getbuffer: view==NULL argument is obsolete");
	return -1;
	}

	void ptr = (void ) PyByteArray_AS_STRING(obj);
	/* cannot fail if view != NULL and readonly == 0 */
	(void)PyBuffer_FillInfo(view, (PyObject*)obj, ptr, Py_SIZE(obj), 0, flags);

	if (flags != PyBUF_SIMPLE) { /* fast path */
	if (flags == PyBUF_READ \|\| flags == PyBUF_WRITE) {
	PyErr_BadInternalCall();
	return -1;
	}

bytearray().__buffer__(256) crashes #126980

Description

Crash report

Linked PRs

Activity

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

`bytearray().buffer(256)` crashes #126980