Repository navigation
SET_OPCODE_OR_RETURN undefined if configured with --disable-gil #126513
Description
Bug report
Bug description:
The latest commit seems to have broken specialized.c when the GIL is disabled.
gcc -c -fno-strict-overflow -Wsign-compare -Wunreachable-code -DNDEBUG -g -O3 -Wall -D_Py_TIER2=1 -D_Py_JIT -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden -I./Include/internal -I./Include/internal/mimalloc -I. -I./Include -DPy_BUILD_CORE -o Python/specialize.o Python/specialize.c
Python/specialize.c:2801:5: error: call to undeclared function 'SET_OPCODE_OR_RETURN'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
2801 | SET_OPCODE_OR_RETURN(instr, CONTAINS_OP);
| ^
1 error generated.
Execute the basic ./configure and compilation succeeds. Add --disable-gil to the configure command line and the above error is generated.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux, macOS
Activity
Eclips4 commentedon Nov 6, 2024
Thanks Skip for the report.
Confirmed on current main
JelleZijlstra commentedon Nov 6, 2024
cc @mpage
Eclips4 commentedon Nov 6, 2024
I can take care of this. It's easy to fix. :)
brettcannon commentedon Nov 6, 2024
In case anyone wants to see the failure in a buildbot, https://buildbot.python.org/all/#/builders/1046/builds/6656 .
gh-126513: Use helpers for `_Py_Specialize_ConstainsOp` (#126517)
Eclips4 commentedon Nov 6, 2024
Fixed in #126517.
pythongh-126513: Use helpers for `_Py_Specialize_ConstainsOp` (python…
pythongh-126513: Use helpers for `_Py_Specialize_ConstainsOp` (python…