Skip to content

The JIT optimizer doesn't know about _BINARY_OP_INPLACE_ADD_UNICODE's store #125912

Closed

Description

@brandtbucher

Bug report

Our abstract interpreter should have a case for _BINARY_OP_INPLACE_ADD_UNICODE, since this "special" instruction includes a store to a fast local. This can mean that the local being stored to is left with stale information (for instance, when analyzing a = ""; a += "spam" the optimizer will incorrectly assume that a still has the value "").

CC @Fidget-Spinner.

Linked PRs

Activity

  1. added
    type-bugAn unexpected behavior, bug, or error
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    3.13only security fixes
    3.14bugs and security fixes
    on Oct 24, 2024
  2. added a commit that references this issue on Oct 28, 2024
  3. added a commit that references this issue on Dec 8, 2024
  4. added a commit that references this issue on Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.13only security fixes3.14bugs and security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)topic-JITtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions