Repository navigation
Invalid datetime.time.fromisoformat #124257
Description
Bug report
Bug description:
According to the standard ISO 8601 Thus the value ‘24:00:00’ is chosen to represent the final instant of the day in order to distinguish the expression of this instant from an expression of a time scale unit.
>>> datetime.time.fromisoformat("24:00")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ValueError: hour must be in 0..23CPython versions tested on:
3.10, 3.12
Operating systems tested on:
Linux, macOS
Activity
eendebakpt commentedon Sep 19, 2024
Some other discussions on supporting this: dotnet/runtime#12197, astropy/astropy#9837
Also note the documentation of
datetime.datetime.fromisoformat:The part "in any valid ISO 8601" suggest that
fromisodateshould support24:00tomasr8 commentedon Sep 19, 2024
On one hand it says
any valid ISO 8601 format(which with the latest amendement to the spec24:00is). On the other hand, it also lists exceptions to the spec. Even though I think it would make sense to support24:00, if it's decided against it, I think we should at least document this discrepancy in the docshugovk commentedon Sep 19, 2024
Is this a duplicate of #102450 (or #54636)?
eendebakpt commentedon Sep 19, 2024
There is an open PR to allow
24:00: #105856. I can review it (but it would be nice to know beforehand whether we actually want to allow24:00).@pganssle @abalkin as code owners