Skip to content

Change base OS image to Ubuntu-24.04 in CI testing #122544

Closed
#122566
Closed
Change base OS image to Ubuntu-24.04 in CI testing#122544
#122566
Labels
infraCI, GitHub Actions, buildbots, Dependabot, etc.type-featureA feature request or enhancement

Description

@Damien-Chen
Damien-Chen
opened on Aug 1, 2024

In current ci.yml, base OS image is ubuntu-22.04, should we move to the latest LTS verion: ubuntu-24.04 ?

pool:
vmImage: ubuntu-22.04

To go further, if we should replace all current CI testing which run on ubuntu-22.04 to ubuntu-24.04 ?

Linked PRs

Activity

  1. Damien-Chen
    added
    type-featureA feature request or enhancement
    on Aug 1, 2024

  2. Eclips4 commented on Aug 1, 2024

    @Eclips4
    Eclips4
    on Aug 1, 2024
    Member

    cc @hugovk @ezio-melotti

  3. Damien-Chen
    changed the title [-]Change base OS image to Ubuntu-24.04 in ci.yaml[/-] [+]Change base OS image to Ubuntu-24.04 in CI testing[/+] on Aug 1, 2024

  4. hugovk commented on Aug 1, 2024

    @hugovk
    hugovk
    on Aug 1, 2024
    Member

    Thanks for the report, we're using ubuntu-22.04 in Read the Docs, Azure Pipelines and GitHub Actions:

    ❯ rg ubuntu-22.04
.readthedocs.yml
11:  os: ubuntu-22.04

.azure-pipelines/ci.yml
8:    vmImage: ubuntu-22.04

.azure-pipelines/pr.yml
8:    vmImage: ubuntu-22.04
20:    vmImage: ubuntu-22.04

.github/workflows/build.yml
47:    runs-on: ubuntu-22.04
198:    runs-on: ubuntu-22.04
264:    runs-on: ubuntu-22.04
378:    runs-on: ubuntu-22.04

.github/workflows/reusable-wasi.yml
12:    runs-on: ubuntu-22.04

.github/workflows/reusable-tsan.yml
22:    runs-on: ubuntu-22.04

.github/workflows/reusable-ubuntu.yml
17:    runs-on: ubuntu-22.04

    Yes, let's upgrade, assuming all the dependencies and everything installs fine.

    Would you like to open some PRs? I suggest a separate PR for each of Read the Docs, Azure Pipelines and GitHub Actions.

  5. Damien-Chen commented on Aug 1, 2024

    @Damien-Chen
    Damien-Chen
    on Aug 1, 2024
    ContributorAuthor

    Sure!, Of course, I'd love to contribute to this, let me first investigate if it would affect the result of CI testing if just simply change ubuntu-22.04 to ubuntu-24.04.

  6. picnixz commented on Aug 1, 2024

    @picnixz
    picnixz
    on Aug 1, 2024
    Member

    We are also using Ubuntu 22.04 for generating the configure script in the Docker image but I don't think we should change this one. This is in Tools/build/regen-configure.sh (I don't know whether the CI/CD is using its own packages or whether is using the docker script to check the configuration scripts)

  7. hugovk commented on Aug 1, 2024

    @hugovk
    hugovk
    on Aug 1, 2024
    Member

    The comment at the top says they should match:

    cpython/Tools/build/regen-configure.sh

    Lines 5 to 8 in fda6bd8

    # The check_generated_files job of .github/workflows/build.yml must kept in
    # sync with this script. Use the same container image than the job so the job
    # doesn't need to run autoreconf in a container.
    IMAGE="ubuntu:22.04"

    Which should be the same as this one:

    cpython/.github/workflows/build.yml

    Lines 43 to 47 in fda6bd8

    check_generated_files:
    name: 'Check if generated files are up to date'
    # Don't use ubuntu-latest but a specific version to make the job
    # reproducible: to get the same tools versions (autoconf, aclocal, ...)
    runs-on: ubuntu-22.04

  8. picnixz commented on Aug 1, 2024

    @picnixz
    picnixz
    on Aug 1, 2024
    Member

    The comment at the top says they should match:

    Oh then we should update both of them then! (and I'll need to update my PR in the devguide as well)

  9. Damien-Chen commented on Aug 2, 2024

    @Damien-Chen
    Damien-Chen
    on Aug 2, 2024
    ContributorAuthor

    Some other yml file based on ubunut-latest, for exmaple: in jit.yml. based on
    https://github.com/actions/runner-images description, ubuntu-latest is actually ubuntu-22.04, should those file mentioned ubuntu-latest need to upgrade ubuntu version ?

         architecture: x86_64

            runner: ubuntu-latest
        compiler: gcc
      - target: x86_64-unknown-linux-gnu/clang
        architecture: x86_64
        runner: ubuntu-latest
        compiler: clang
      - target: aarch64-unknown-linux-gnu/gcc
        architecture: aarch64
        runner: ubuntu-latest
        compiler: gcc
      - target: aarch64-unknown-linux-gnu/clang
        architecture: aarch64
        runner: ubuntu-latest
        compiler: clang

  10. hugovk commented on Aug 2, 2024

    @hugovk
    hugovk
    on Aug 2, 2024
    Member

    No, let's not change any ubuntu-latest.

    In fact, https://github.com/actions/runner-images?tab=readme-ov-file#available-images says ubuntu-24.04 is still beta, maybe we should wait until it is in GA (General Availability)?

    Do you know when GA is planned?

  11. Damien-Chen commented on Aug 2, 2024

    @Damien-Chen
    Damien-Chen
    on Aug 2, 2024
    ContributorAuthor

    According to there discussion in
    actions/runner-images#9691
    The GA will be somewhere in August-2024, I think it should be soon.

    I think we can move all CI-testing step-by-step.
    First change trivial CI testiing(like readthedocs) to ubuntu-24.04 to make sure everything works correctly.
    If everthing goes well, then we can wait its GA and move core part(like checking JIT) to ubuntu-24.04 gradually

  12. hugovk
    added a commit that references this issue on Aug 2, 2024

    gh-122544: Change OS image in readthedocs.yml to ubuntu-24.04 (#122568)

    d57f8a9
  13. miss-islington
    added 2 commits that reference this issue on Aug 2, 2024

    pythongh-122544: Change OS image in readthedocs.yml to ubuntu-24.04 (p…

    dd34ac9

    pythongh-122544: Change OS image in readthedocs.yml to ubuntu-24.04 (p…

    4d2afb0
  14. hugovk
    added a commit that references this issue on Aug 2, 2024

    [3.13] gh-122544: Change OS image in readthedocs.yml to ubuntu-24.04 (G…

    bc1e522

  15. 20 remaining items

  16. Damien-Chen
    added 2 commits that reference this issue on Nov 9, 2024

    [3.13]pythongh-122544: Change OS image in GitHub Actions to Ubuntu 24…

    23e6cfe

    pythongh-122544: Change OS image in GitHub Actions to Ubuntu 24.04 (p…

    eb3b57e
  17. ambv
    added a commit that references this issue on Nov 22, 2024

    [3.13] gh-122544: Change OS image in GitHub Actions to Ubuntu 24.04 (#…

    950daf8

  18. luapun commented on Nov 25, 2024

    @luapun
    luapun
    on Nov 25, 2024 · Hidden as spam

  19. luapun commented on Nov 25, 2024

    @luapun
    luapun
    on Nov 25, 2024 · Hidden as spam
  20. picnixz
    added 2 commits that reference this issue on Dec 8, 2024

    pythongh-122544: Change OS image in Azure pipeline to Ubuntu 24.04 (p…

    6d994e5

    pythongh-122544: Change OS image in GitHub Actions to Ubuntu 24.04 (p…

    41f1214
  21. hugovk
    added a commit that references this issue on Jan 11, 2025

    [3.12] gh-122544: Change OS image in GitHub Actions to Ubuntu 24.04 (#…

    a600439
  22. ebonnal
    added 2 commits that reference this issue on Jan 12, 2025

    pythongh-122544: Change OS image in Azure pipeline to Ubuntu 24.04 (p…

    cc4bcd1

    pythongh-122544: Change OS image in GitHub Actions to Ubuntu 24.04 (p…

    619e390
  23. hugovk
    added a commit that references this issue on Feb 18, 2025

    pythongh-122544: Change OS image in GitHub Actions to Ubuntu 24.04 (p…

    f79addb
  24. pablogsal
    added a commit that references this issue on Feb 18, 2025

    [3.11] gh-122544: Change OS image in GitHub Actions to Ubuntu 24.04 (#…

    b2c3a95
  25. hugovk
    added a commit that references this issue on Feb 19, 2025

    pythongh-122544: Change OS image in GitHub Actions to Ubuntu 24.04 (p…

    9e4f67c
  26. ambv
    added 2 commits that reference this issue on Feb 19, 2025

    [3.10] gh-122544: Change OS image in GitHub Actions to Ubuntu 22.04 (G…

    457b2ca

    [3.9] gh-122544: Change OS image in GitHub Actions to Ubuntu 22.04 (#…

    8a417ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    infraCI, GitHub Actions, buildbots, Dependabot, etc.type-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions