Repository navigation
Emscripten trampolines not quite right since #106219 #121700
Description
Bug report
Bug description:
pycore_emscripten_trampoline.h defines _PyCFunctionWithKeywords_TrampolineCall as a macro but pycore_object.h tries to declare it. This leads to a compile error. The fix is to delete the declaration from pycore_object.h.
--- a/Include/internal/pycore_object.h
+++ b/Include/internal/pycore_object.h
@@ -733,13 +733,7 @@ PyAPI_FUNC(PyObject*) _PyObject_GetState(PyObject *);
* Third party code unintentionally rely on problematic fpcasts. The call
* trampoline mitigates common occurrences of bad fpcasts on Emscripten.
*/
-#if defined(__EMSCRIPTEN__) && defined(PY_CALL_TRAMPOLINE)
-#define _PyCFunction_TrampolineCall(meth, self, args) \
- _PyCFunctionWithKeywords_TrampolineCall( \
- (*(PyCFunctionWithKeywords)(void(*)(void))(meth)), (self), (args), NULL)
-extern PyObject* _PyCFunctionWithKeywords_TrampolineCall(
- PyCFunctionWithKeywords meth, PyObject *, PyObject *, PyObject *);
-#else
+#if !(defined(__EMSCRIPTEN__) && defined(PY_CALL_TRAMPOLINE))
#define _PyCFunction_TrampolineCall(meth, self, args) \
(meth)((self), (args))
#define _PyCFunctionWithKeywords_TrampolineCall(meth, self, args, kw) \CPython versions tested on:
CPython main branch
Operating systems tested on:
Other
Activity
pythongh-121700 Emscripten trampolines not quite right since python#1…
gh-121700 Emscripten trampolines not quite right since #106219 (GH-12…
pythongh-121700 Emscripten trampolines not quite right since pythonGH…
[3.13] gh-121700 Emscripten trampolines not quite right since GH-106219…
pythongh-121700 Emscripten trampolines not quite right since python#1…
pythongh-121700 Shorten Emscripten trampolines by a little