You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
zipfile: Deduplicate reinitialization setup for ZipExtFile when seeking #121639
ZipExtFile needs to be reinitialized if seeking back beyond it's current buffered data. The code to initialize and then reinitialize are in 2 locations and consolidating these into one location reduces the footprint for introducing potential bugs.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
I forgot I created an issue and PR (#88294) for this a few years ago. Originally this change was split out of a bug fix and I guess I forgot I had created that follow up work :p
In any case, the PR attached to this issue will merge cleanly whereas the old PR would need a little bit of work (#26116).
Activity
pythongh-121639: Deduplicate reinitialization setup for ZipExtFile wh…
danifus commentedon Jul 22, 2024
I forgot I created an issue and PR (#88294) for this a few years ago. Originally this change was split out of a bug fix and I guess I forgot I had created that follow up work :p
In any case, the PR attached to this issue will merge cleanly whereas the old PR would need a little bit of work (#26116).
Export wave-2 takeover patches (zipfile pythongh-121639, smtplib pyth…