Skip to content

zipfile: Deduplicate reinitialization setup for ZipExtFile when seeking #121639

Description

@danifus

Feature or enhancement

Proposal:

ZipExtFile needs to be reinitialized if seeking back beyond it's current buffered data. The code to initialize and then reinitialize are in 2 locations and consolidating these into one location reduces the footprint for introducing potential bugs.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

Activity

  1. added a commit that references this issue on Jul 12, 2024
  2. danifus commented on Jul 22, 2024

    @danifus
    ContributorAuthor

    I forgot I created an issue and PR (#88294) for this a few years ago. Originally this change was split out of a bug fix and I guess I forgot I had created that follow up work :p

    In any case, the PR attached to this issue will merge cleanly whereas the old PR would need a little bit of work (#26116).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-featureA feature request or enhancement

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions