Repository navigation
asyncio thread-safety issues in the free-threaded build #120974
Description
Bug report
fi_freelistisn't thread-safe (move topycore_freelist.hand follow that pattern)enter_task,leave_task, andswap_current_taskaren't thread-safe due to sharedstate->current_tasksand borrowed references.register_taskandunregister_taskaren't thread-safe due to sharedstate->asyncio_taskslinked list_asyncio_all_tasks_implisn't thread-safe due the theasyncio_taskslinked list.
For 2, 3, and 4, we can consider using critical sections to protect the accesses to state->current_tasks and state->asyncio_tasks.
Longer term, moving data to per-loop will probably help with multi-threaded scaling.
Linked PRs
- gh-120974: Use common freelist code in asyncio #122132
- gh-120974: Make _asyncio._enter_task atomic in the free-threaded build #122138
- gh-120974: Make _asyncio._leave_task atomic in the free-threaded build #122139
- [3.13] gh-120974: Make _asyncio._enter_task atomic in the free-threaded build (GH-122138) #122152
- [3.13] gh-120974: Make _asyncio._leave_task atomic in the free-threaded build (GH-122139) #122186
- gh-120974: Make asyncio
swap_current_tasksafe in free-threaded build #122317 - [3.13] gh-120974: Make asyncio
swap_current_tasksafe in free-threaded build (GH-122317) #122612 - GH-120974: make _asyncio_all_tasks_impl thread safe #122801
Activity
kumaraditya303 commentedon Jun 25, 2024
I think that the pure Python fallback isn't thread safe either, FWIW I think there are more thread safety issues than these, asyncio code was written with assumption of GIL.
corona10 commentedon Jun 25, 2024
Yeah, but for landing PEP 703, we are trying to change modules, not depending on the GIL, even if we need to re-write some parts of the implementation with a conditional flag. (If the new written part requires some performance overhead)
pythongh-120974: Use common freelist code in asyncio
pythongh-120974: Make _asyncio._enter_task atomic in the free-threade…
pythongh-120974: Make _asyncio._leave_task atomic in the free-threade…
gh-120974: Make _asyncio._enter_task atomic in the free-threaded build (
pythongh-120974: Make _asyncio._enter_task atomic in the free-threade…
[3.13] gh-120974: Make _asyncio._enter_task atomic in the free-thread…
6 remaining items
pythongh-120974: Make _asyncio._leave_task atomic in the free-threade…
pythongh-120974: Make _asyncio._enter_task atomic in the free-threade…
pythongh-120974: Use common freelist code in asyncio (python#122132)
pythongh-120974: Make _asyncio._leave_task atomic in the free-threade…
pythongh-120974: Make asyncio `swap_current_task` safe in free-thread…
pythongh-120974: Make asyncio `swap_current_task` safe in free-thread…
gh-120974: Make asyncio `swap_current_task` safe in free-threaded bui…
pythongh-120974: Make asyncio `swap_current_task` safe in free-thread…
[3.13] gh-120974: Make asyncio `swap_current_task` safe in free-threa…
pythongh-120974: Make asyncio `swap_current_task` safe in free-thread…
GH-120974: make `_asyncio.all_tasks` thread safe (#122801)
pythongh-120974: Make asyncio `swap_current_task` safe in free-thread…
pythonGH-120974: make `_asyncio.all_tasks` thread safe (python#122801)