You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add INSTRUCTION_SIZE macro to code generator. #118423
In bytecodes.c we use both next_instr - this_instr and 1 + INLINE_CACHE_ENTRIES_... to mean "instruction length".
We should add a macro for the purpose that is understood by the code generator.
Examples
The somewhat confusing LOAD_IP(1 + INLINE_CACHE_ENTRIES_SEND); would become LOAD_IP(INSTRUCTION_LENGTH)
frame->return_offset = (uint16_t)(next_instr - this_instr); would become frame->return_offset = INSTRUCTION_LENGTH; which is both easier to understand and wouldn't be rejected as tier 2 code.
Activity
gh-118423: Add `INSTRUCTION_SIZE` macro to code generator (GH-125467)
pythongh-118423: Add `INSTRUCTION_SIZE` macro to code generator (pyth…
Fidget-Spinner commentedon Dec 23, 2024
I think this is done. So I'll close the issue.
pythongh-118423: Add `INSTRUCTION_SIZE` macro to code generator (pyth…