Skip to content

_testexternalinspection.c doesn't check for undefined TARGET_OS_OSX #117891

Closed
#118073
Closed
_testexternalinspection.c doesn't check for undefined TARGET_OS_OSX#117891
#118073
Labels
OS-macextension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

Description

@jmroot
jmroot
opened on Apr 15, 2024

Bug report

Bug description:

Similar to #117886, TARGET_OS_OSX is not defined by older macOS SDKs, and the code doesn't distinguish between it being undefined and being defined to 0.

CPython versions tested on:

3.13

Operating systems tested on:

macOS

Linked PRs

Activity

  1. jmroot
    added
    type-bugAn unexpected behavior, bug, or error
    on Apr 15, 2024
  2. jmroot
    added a commit that references this issue on Apr 15, 2024

    pythongh-117891: handle undefined TARGET_OS_OSX

    e76913f
  3. erlend-aasland
    added
    OS-mac
    extension-modulesC modules in the Modules dir
    on Apr 15, 2024
  4. ned-deily
    closed this as completedin #118073on Apr 19, 2024

  5. ned-deily commented on Apr 19, 2024

    @ned-deily
    ned-deily
    on Apr 19, 2024
    Member

    Thanks again for the issue. As discussed in the associated PR #117887, the suggested change has been rolled up and merged in PR #118073.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    OS-macextension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions