New warning: ‘fmt’ may be used uninitialized in this function [-Wmaybe-uninitialized]

Bug report

Bug description:

Popped up in https://github.com/python/cpython/pull/116101/files and https://github.com/python/cpython/pull/116096/files

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

gh-116102: Silence a Compiler Warning in _xxinterpqueues #116230

Thanks a lot for your helpful reports!

I wanted to post the same :)

@ericsnowcurrently

I think that there are multiple issues here:

» ./python.exe
Python 3.13.0a4+ (heads/main:186fa938766, Feb 29 2024, 13:50:11) [Clang 15.0.0 (clang-1500.0.40.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import _xxinterpqueues
>>> a = _xxinterpqueues.create(2, 0)
>>> _xxinterpqueues.get(a, 'a')
('a', 3)
>>> 
KeyboardInterrupt
>>> ^D
Assertion failed: (queues->count == 0), function _queues_fini, file _xxinterpqueuesmodule.c, line 689.
[1]    57640 abort      ./python.exe

Why ('a', 3) is returned? 3 is not the default fmt for this queue
Why does it crash? Assertion failed: (queues->count == 0), function _queues_fini, file _xxinterpqueuesmodule.c, line 689.

CC @ericsnowcurrently

Why ('a', 3) is returned? 3 is not the default fmt for this queue

It should have raised QueueEmpty. When run your code locally I get QueueEmpty.

Why does it crash? Assertion failed: (queues->count == 0), function _queues_fini, file _xxinterpqueuesmodule.c, line 689.

I'm going to look into this.

gh-116102: Silence a Compiler Warning in _xxinterpqueues (gh-116230)

I've fixed the warning.

As to "Why does it crash?", it's because the low-level module requires you to call _xxinterpqueues.destroy(). Note that I didn't really intend for people to use the low-level module directly. If this is a problem, we can address it separately from this issue.

@ericsnowcurrently

@ericsnowcurrently I will open a new one, because I don't have the same result as you with QueueEmpty :(

Done: #116239

If this is a problem, we can address it separately from this issue.

Can we call .destroy() on module shut-down? It might fix this problem.
Tell me to open a new issue if you think that this is worth fixing, though :)

pythongh-116102: Silence a Compiler Warning in _xxinterpqueues (pytho…

Can we call .destroy() on module shut-down? It might fix this problem.

I'm taking care of this in gh-116328.

pythongh-116102: Silence a Compiler Warning in _xxinterpqueues (pytho…

Navigation Menu

Repository navigation

New warning: `‘fmt’ may be used uninitialized in this function [-Wmaybe-uninitialized]` #116102

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

New warning: ‘fmt’ may be used uninitialized in this function [-Wmaybe-uninitialized] #116102

Description

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Activity

sobolevn commented on Feb 29, 2024

sobolevn commented on Feb 29, 2024

ericsnowcurrently commented on Mar 1, 2024

ericsnowcurrently commented on Mar 2, 2024

sobolevn commented on Mar 2, 2024

sobolevn commented on Mar 2, 2024

sobolevn commented on Mar 2, 2024

ericsnowcurrently commented on Mar 4, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

New warning: `‘fmt’ may be used uninitialized in this function [-Wmaybe-uninitialized]` #116102