Repository navigation
Add variant of Py_BEGIN_CRITICAL_SECTION that accepts a NULL argument #115432
Description
Feature or enhancement
We should add a variant of Py_BEGIN_CRITICAL_SECTION / Py_END_CRITICAL_SECTION that accepts a possibly NULL object. If the passed object is NULL then nothing is locked or unlocked. Otherwise, it behaves like Py_BEGIN_CRITICAL_SECTION.
For example:
PyObject *object = maybe ? real_object : NULL;
Py_XBEGIN_CRITICAL_SECTION(object);
...
Py_XEND_CRITICAL_SECTION();This will be useful in making set thread-safe. There are a number of functions that take an optional iterable that may be NULL. We want to lock it in the cases where it's not NULL.
I don't think we will need a version of Py_BEGIN_CRITICAL_SECTION2 that accepts optionally NULL arguments.
Activity
pythongh-115432: Add critical section variant that handles a NULL object
gh-115432: Add critical section variant that handles a NULL object (#…
colesbury commentedon Mar 19, 2024
It turns out that we are not using this in
set(or anywhere else), so I think we should revert the PR.pythongh-115432: Add critical section variant that handles a NULL obj…
Revert "pythongh-115432: Add critical section variant that handles a …
Revert "gh-115432: Add critical section variant that handles a NULL o…
Revert "pythongh-115432: Add critical section variant that handles a …
[3.13] Revert "gh-115432: Add critical section variant that handles a…
Revert "pythongh-115432: Add critical section variant that handles a …
pythongh-115432: Add critical section variant that handles a NULL obj…