Skip to content

Consider avoiding the dependency on quay.io server in the GitHub Action "Check if generated files are up to date" job #112088

Closed
Closed
Consider avoiding the dependency on quay.io server in the GitHub Action "Check if generated files are up to date" job#112088
Labels
3.12only security fixes3.13only security fixesbuildThe build process and cross-build

Description

@vstinner
vstinner
opened on Nov 14, 2023

Last weeks/months, the quay.io server failed time time time. The problem is that the Python workflow has a GitHub Action "Check if generated files are up to date" job which pulls a container image from quay.io to run the make regen-configure command.

Should we consider avoiding the dependency on the quay.io server to make our workflow more reliable?

Linked PRs

Activity

  1. vstinner commented on Nov 14, 2023

    @vstinner
    vstinner
    on Nov 14, 2023
    MemberAuthor

    Recently, I documented commands to run make regen-configure with no container: https://docs.python.org/dev/using/configure.html#generated-files

    I tried to run autoreconf -ivf -Werror in an Ubuntu 22.04 container (same Ubuntu version than the one currently used by the GHA job) to see if we can get the exact output. Sadly, it changes the output :-(

    On Fedora, I create an Ubuntu 22.04 container with:

    podman image pull ubuntu:22.04
podman image list --all
podman run --name ubuntu-dev --hostname ubuntu-dev --interactive --tty ubuntu:22.04

    Commands which are supposed to produce the same output than make regen-configure:

    apt update
apt install -y git autotools-dev autoconf autoconf-archive pkgconf
git clone https://github.com/python/cpython/ --depth=1
cd cpython/
autoreconf -ivf -Werror
git diff

    Output:

    diff --git a/aclocal.m4 b/aclocal.m4
index da8ee95..b309f4d 100644
--- a/aclocal.m4
+++ b/aclocal.m4
@@ -1,4 +1,4 @@
-# generated automatically by aclocal 1.16.4 -*- Autoconf -*-
+# generated automatically by aclocal 1.16.5 -*- Autoconf -*-
 
 # Copyright (C) 1996-2021 Free Software Foundation, Inc.

    Versions retrieved by dpkg -l|grep -E 'autotools|autoconf|pkgconf':

    • autoconf 2.71-2
    • autoconf-archive 20210219-2.1
    • autotools-dev 20220109.1
    • libpkgconf3:amd64 1.8.0-1
    • pkgconf 1.8.0-1

  2. vstinner commented on Nov 14, 2023

    @vstinner
    vstinner
    on Nov 14, 2023
    MemberAuthor

    cc @erlend-aasland

  3. vstinner commented on Nov 14, 2023

    @vstinner
    vstinner
    on Nov 14, 2023
    MemberAuthor

    Last weeks/months, the quay.io server failed time time time.

    Example:

    Trying to pull quay.io/tiran/cpython_autoconf:271...
Error: initializing source docker://quay.io/tiran/cpython_autoconf:271: reading manifest 271 in quay.io/tiran/cpython_autoconf: received unexpected HTTP status: 504 Gateway Time-out

    build: https://github.com/python/cpython/actions/runs/6869118007/job/18682243065?pr=112063

  4. vstinner commented on Nov 14, 2023

    @vstinner
    vstinner
    on Nov 14, 2023
    MemberAuthor

    This latest server issue is tracked at: https://status.quay.io/incidents/z7sbjqmb34p1

  5. vstinner
    added a commit that references this issue on Nov 14, 2023

    pythongh-112088: Run autoreconf in GHA check_generated_files

    66a3210

  6. vstinner commented on Nov 14, 2023

    @vstinner
    vstinner
    on Nov 14, 2023
    MemberAuthor

    The server fails with different errors:

    podman run --rm --pull=always -v /home/runner/work/cpython/cpython:/src quay.io/tiran/cpython_autoconf:271
Trying to pull quay.io/tiran/cpython_autoconf:271...
Error: initializing source docker://quay.io/tiran/cpython_autoconf:271: can't talk to a V1 container registry

  7. vstinner commented on Nov 14, 2023

    @vstinner
    vstinner
    on Nov 14, 2023
    MemberAuthor

    apt install -y git autotools-dev autoconf autoconf-archive pkgconf

    Hum, pkg-config should be installed, not pkgconf.

  8. vstinner
    added a commit that references this issue on Nov 14, 2023

    pythongh-112088: Run autoreconf in GHA check_generated_files

    7f3e933

  9. vstinner commented on Nov 14, 2023

    @vstinner
    vstinner
    on Nov 14, 2023
    MemberAuthor

    This latest server issue is tracked at: https://status.quay.io/incidents/z7sbjqmb34p1

    Recent https://status.quay.io/ events:

  10. vstinner
    added 2 commits that reference this issue on Nov 15, 2023

    pythongh-112088: Run autoreconf in GHA check_generated_files

    e713876

    pythongh-112088: Run autoreconf in GHA check_generated_files

    4f8987f
  11. erlend-aasland
    added
    buildThe build process and cross-build
    3.12only security fixes
    3.13only security fixes
    on Nov 15, 2023
  12. vstinner
    added a commit that references this issue on Nov 15, 2023

    gh-112088: Run autoreconf in GHA check_generated_files (#112090)

    d9fd33a
  13. miss-islington
    added a commit that references this issue on Nov 15, 2023

    pythongh-112088: Run autoreconf in GHA check_generated_files (pythonG…

    fa50d69
  14. vstinner
    closed this as completedon Nov 15, 2023
  15. vstinner
    added 2 commits that reference this issue on Nov 16, 2023

    pythongh-112088: Run autoreconf in GHA check_generated_files (python#…

    216b01c

    [3.12] gh-112088: Run autoreconf in GHA check_generated_files (GH-112090

    a498433
  16. aisk
    added a commit that references this issue on Feb 11, 2024

    pythongh-112088: Run autoreconf in GHA check_generated_files (python#…

    52b93a4
  17. Glyphack
    added a commit that references this issue on Sep 2, 2024

    pythongh-112088: Run autoreconf in GHA check_generated_files (python#…

    2882f6b
  18. efimov-mikhail
    added a commit that references this issue on Oct 14, 2024

    pythongh-112088: aclocal version is updated to 1.16.5 in docs

    3f67be2
  19. vstinner
    added a commit that references this issue on Oct 14, 2024

    gh-112088: aclocal version is updated to 1.16.5 in docs (#125457)

    45df264
  20. miss-islington
    added a commit that references this issue on Oct 14, 2024

    pythongh-112088: aclocal version is updated to 1.16.5 in docs (python…

    ee65431
  21. vstinner
    added a commit that references this issue on Oct 14, 2024

    [3.13] gh-112088: aclocal version is updated to 1.16.5 in docs (GH-12…

    6c81928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.12only security fixes3.13only security fixesbuildThe build process and cross-build

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions