Skip to content

test_zlib uses some very old random API #110332

Closed
Closed
test_zlib uses some very old random API#110332
Assignees
sobolevn
Labels
testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Description

@sobolevn
sobolevn
opened on Oct 4, 2023

Bug report

Here's the problematic code:

cpython/Lib/test/test_zlib.py

Lines 513 to 525 in 1465386

# Try 17K of data
# generate random data stream
try:
# In 2.3 and later, WichmannHill is the RNG of the bug report
gen = random.WichmannHill()
except AttributeError:
try:
# 2.2 called it Random
gen = random.Random()
except AttributeError:
# others might simply have a single RNG
gen = random
gen.seed(1)

It always fails with AttributeError, because random.WichmannHill() does not exist.

This is some old compatibility class that was removed a long time ago:

The attributes random.whseed and random.__whseed have no meaning for
  the new generator.  Code using these attributes should switch to a
  new class, random.WichmannHill which is provided for backward
  compatibility and to make an alternate generator available.

So, I propose to simplify this test.

Linked PRs

Activity

  1. sobolevn
    added
    type-bugAn unexpected behavior, bug, or error
    testsTests in the Lib/test dir
    on Oct 4, 2023
  2. sobolevn
    self-assigned this
    on Oct 4, 2023
  3. sobolevn
    added 2 commits that reference this issue on Oct 4, 2023

    pythongh-110332: Remove mentions of `random.WichmannHill` from `test_…

    3871f9c

    pythongh-110332: Remove mentions of `random.WichmannHill` from `test_…

    04a8df2
  4. vstinner
    added a commit that references this issue on Oct 4, 2023

    gh-110332: Remove mentions of `random.WichmannHill` from `test_zlib` (#…

    e9f2352
  5. miss-islington
    added 2 commits that reference this issue on Oct 4, 2023

    pythongh-110332: Remove mentions of `random.WichmannHill` from `test_…

    b49710b

    pythongh-110332: Remove mentions of `random.WichmannHill` from `test_…

    142c112
  6. vstinner
    added 2 commits that reference this issue on Oct 4, 2023

    [3.11] gh-110332: Remove mentions of `random.WichmannHill` from `test…

    d507493

    [3.12] gh-110332: Remove mentions of `random.WichmannHill` from `test…

    f53871e

  7. AlexWaygood commented on Oct 4, 2023

    @AlexWaygood
    AlexWaygood
    on Oct 4, 2023
    Member

    Thanks!

  8. AlexWaygood
    closed this as completedon Oct 4, 2023
  9. Glyphack
    added a commit that references this issue on Sep 2, 2024

    pythongh-110332: Remove mentions of `random.WichmannHill` from `test_…

    52dec87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions