You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Consider adding test_type_aliases and test_type_params to PGO suite #110282
I don't have good intuition on what should and should not be added to the PGO build, but here's some thoughts:
On the plus side, these tests are really fast (I just ran test_type_params in 198 ms, test_type_aliases in 76 ms, and test_typing in 677 ms). So if we add them, the cost is low in terms of slowing down the PGO build.
On the negative side, I'm not sure it helps us all that much. The code paths exercised by these typing tests generally shouldn't be hot at runtime (you only execute your type annotations once), so having PGO focus on it doesn't seem all that helpful.
Activity
[-]Consider adding `test_[/-][+]Consider adding `test_type_aliases` and `test_type_params` to PGO suite[/+]sobolevn commentedon Oct 3, 2023
And maybe even
test_typing?vstinner commentedon Oct 3, 2023
I'm not the right person to ask about performance and trying PGO build.
@gvanrossum: Any idea if something should be done to optimize Python performance for the typing module?
JelleZijlstra commentedon Oct 3, 2023
I don't have good intuition on what should and should not be added to the PGO build, but here's some thoughts: