Skip to content

test_enum has duplicate test cases: function vs class based enum definitions #109774

Closed as not planned
Closed as not planned
test_enum has duplicate test cases: function vs class based enum definitions#109774
Assignees
sobolevnethanfurman
Labels
stdlibStandard Library Python modules in the Lib/ directorytestsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Description

@sobolevn
sobolevn
opened on Sep 23, 2023

Bug report

cpython/Lib/test/test_enum.py

Lines 1034 to 1047 in 5e7ea95

class TestPlainEnumClass(_EnumTests, _PlainOutputTests, unittest.TestCase):
enum_type = Enum
class TestPlainEnumFunction(_EnumTests, _PlainOutputTests, unittest.TestCase):
enum_type = Enum
class TestPlainFlagClass(_EnumTests, _PlainOutputTests, _FlagTests, unittest.TestCase):
enum_type = Flag
class TestPlainFlagFunction(_EnumTests, _PlainOutputTests, _FlagTests, unittest.TestCase):
enum_type = Flag

Looks like some cases here are just duplicates: because in some cases Function and Class tests have different enum_type definitions:

cpython/Lib/test/test_enum.py

Lines 1104 to 1109 in 5e7ea95

class TestMixedIntClass(_EnumTests, _MixedOutputTests, unittest.TestCase):
class enum_type(int, Enum): pass
class TestMixedIntFunction(_EnumTests, _MixedOutputTests, unittest.TestCase):
enum_type = Enum('enum_type', type=int)

But, some have identical. I propose to delete cases where enum_type is a duplicate.
I have a PR ready.

It was introduced in #108704
CC @ethanfurman

Linked PRs

Activity

  1. sobolevn
    added
    type-bugAn unexpected behavior, bug, or error
    testsTests in the Lib/test dir
    stdlibStandard Library Python modules in the Lib/ directory
    on Sep 23, 2023
  2. sobolevn
    self-assigned this
    on Sep 23, 2023
  3. sobolevn
    added a commit that references this issue on Sep 23, 2023

    pythongh-109774: Remove duplicated tests from `test_enum`

    2a02037
  4. ethanfurman
    self-assigned this
    on Sep 23, 2023

  5. ethanfurman commented on Sep 23, 2023

    @ethanfurman
    ethanfurman
    on Sep 23, 2023
    Member

    Those duplicates are intentional -- the functional creation tests excercise different code than the class creation tests.

  6. itamaro
    closed this as not plannedon Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

stdlibStandard Library Python modules in the Lib/ directorytestsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions