Skip to content

test_site: test_underpth_basic() fails if the current directory is non-ASCII #109237

Closed
Closed
test_site: test_underpth_basic() fails if the current directory is non-ASCII#109237
Labels
testsTests in the Lib/test dir

Description

@vstinner
vstinner
opened on Sep 10, 2023

Failure on GHA Windows x64 CI with PR #109229 which runs test_site in a non-ASCII working directory:

FAIL: test_underpth_basic (test.test_site._pthFileTests.test_underpth_basic)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_site.py", line 621, in test_underpth_basic
    self.assertEqual(
AssertionError: Lists differ: ['D:\[40 chars]_1460\udce6', 'D:\\a\\cpython\\cpython\\PCbuil[396 chars]18f'] != ['D:\[40 chars]_1460�', 'D:\\a\\cpython\\cpython\\PCbuild\\am[391 chars]18f']

First differing element 0:
'D:\\a\\cpython\\cpython\\build\\test_python_1460\udce6'
'D:\\a\\cpython\\cpython\\build\\test_python_1460�'

Diff is 690 characters long. Set self.maxDiff to None to see it. : sys.path is incorrect

build: https://github.com/python/cpython/actions/runs/6138224249/job/16654899364?pr=109229

Linked PRs

Activity

  1. vstinner
    added
    testsTests in the Lib/test dir
    on Sep 10, 2023
  2. vstinner
    added a commit that references this issue on Sep 10, 2023

    pythongh-109237: Fix test_site for non-ASCII working directory

    ca83696

  3. vstinner commented on Sep 10, 2023

    @vstinner
    vstinner
    on Sep 10, 2023
    MemberAuthor

    Example:

    vstinner@WIN C:\victor\python\main>mkdir héhé

vstinner@WIN C:\victor\python\main>cd héhé

vstinner@WIN C:\victor\python\main\héhé>..\python -m test test_site -v
(...)
======================================================================
FAIL: test_underpth_basic (test.test_site._pthFileTests.test_underpth_basic)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\victor\python\main\Lib\test\test_site.py", line 621, in test_underpth_basic
    self.assertEqual(
AssertionError: Lists differ: ['C:\[19 chars]in\\h\udce9h\udce9', 'C:\\victor\\python\\main[361 chars]emp'] != ['C:\[19 chars]in\\héhé', 'C:\\victor\\python\\main\\PCbuild\[351 chars]emp']

First differing element 0:
'C:\\victor\\python\\main\\h\udce9h\udce9'
'C:\\victor\\python\\main\\héhé'

- ['C:\\victor\\python\\main\\h\udce9h\udce9',
?                              ^^^^^^ ^^^^^^

+ ['C:\\victor\\python\\main\\héhé',
?                              ^ ^

   'C:\\victor\\python\\main\\PCbuild\\amd64\\python313_d.zip',
   'C:\\victor\\python\\main\\PCbuild\\amd64',
   'C:\\victor\\python\\main\\Lib',
   'C:\\Users\\vstinner\\AppData\\Roaming\\Python\\Python313\\site-packages',
   'C:\\victor\\python\\main',
   'C:\\victor\\python\\main\\Lib\\site-packages',
   'C:\\Users\\vstinner\\AppData\\Local\\Temp\\tmpesrsy5ed',
   'C:\\Users\\vstinner\\AppData\\Local\\Temp'] : sys.path is incorrect

----------------------------------------------------------------------
Ran 32 tests in 2.619s

FAILED (failures=1, skipped=2)
(...)
  4. vstinner
    added a commit that references this issue on Sep 10, 2023

    gh-109237: Fix test_site for non-ASCII working directory (#109238)

    cbb3a6f
  5. miss-islington
    added 2 commits that reference this issue on Sep 10, 2023

    pythongh-109237: Fix test_site for non-ASCII working directory (pytho…

    97d7a56

    pythongh-109237: Fix test_site for non-ASCII working directory (pytho…

    3090115
  6. vstinner
    added a commit that references this issue on Sep 10, 2023

    [3.11] gh-109237: Fix test_site for non-ASCII working directory (GH-1…

    cef4951
  7. Yhg1s
    added a commit that references this issue on Sep 12, 2023

    [3.12] gh-109237: Fix test_site for non-ASCII working directory (GH-1…

    b361381
  8. vstinner
    closed this as completedon Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dir

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions