Skip to content

test_pyexpat: test_exception() fails on Ubuntu and macOS jobs on GitHub Actions #109230

Closed
Closed
test_pyexpat: test_exception() fails on Ubuntu and macOS jobs on GitHub Actions#109230
Labels
testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Description

@vstinner
vstinner
opened on Sep 10, 2023
FAIL: test_exception (test.test_pyexpat.HandlerExceptionTest.test_exception)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_pyexpat.py", line 452, in test_exception
    parser.Parse(b"<a><b><c/></b></a>", True)
  File "../cpython-ro-srcdir/Modules/pyexpat.c", line 421, in StartElement
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_pyexpat.py", line 442, in StartElementHandler
    raise RuntimeError(name)
RuntimeError: a

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_pyexpat.py", line 472, in test_exception
    self.assertIn('call_with_frame("StartElement"', entries[1][3])
AssertionError: 'call_with_frame("StartElement"' not found in ''

Comparison of Ubuntu logs:

Linked PRs

Activity

  1. vstinner
    changed the title [-]test_pyexpat: [/-] [+]test_pyexpat: test_exception() fails on Ubuntu and macOS jobs on GitHub Actions[/+] on Sep 10, 2023
  2. vstinner
    added
    type-bugAn unexpected behavior, bug, or error
    testsTests in the Lib/test dir
    on Sep 10, 2023

  3. vstinner commented on Sep 10, 2023

    @vstinner
    vstinner
    on Sep 10, 2023
    MemberAuthor

    Oh wait. Maybe it's a real bug in my PR #109229.

  4. vstinner commented on Sep 10, 2023

    @vstinner
    vstinner
    on Sep 10, 2023
    MemberAuthor

    Oh. This test depends on the current working directory!

    If it's run from the source directory, it pass.

    $ pwd
/home/vstinner/python/main

$ ls Modules/pyexpat.c
Modules/pyexpat.c

vstinner@mona$ ./python -m test -v test_pyexpat -m test_exception  -q
(...)
Result: SUCCESS

    If it's run from a different directory, it fails!

    $ cd ..

$ pwd
/home/vstinner/python

$ ls Modules/pyexpat.c
ls: cannot access 'Modules/pyexpat.c': No such file or directory

$ main/python -m test -v test_pyexpat -m test_exception  -q
(...)
test test_pyexpat failed -- Traceback (most recent call last):
  File "/home/vstinner/python/main/Lib/test/test_pyexpat.py", line 452, in test_exception
    parser.Parse(b"<a><b><c/></b></a>", True)
  File "./Modules/pyexpat.c", line 421, in StartElement
  File "/home/vstinner/python/main/Lib/test/test_pyexpat.py", line 442, in StartElementHandler
    raise RuntimeError(name)
RuntimeError: a

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/vstinner/python/main/Lib/test/test_pyexpat.py", line 472, in test_exception
    self.assertIn('call_with_frame("StartElement"', entries[1][3])
AssertionError: 'call_with_frame("StartElement"' not found in ''

(...)
Result: FAILURE

  5. vstinner commented on Sep 10, 2023

    @vstinner
    vstinner
    on Sep 10, 2023
    MemberAuthor

    The test checks that the traceback module is able to read a line of the Python C code in Modules/pyexpat.c. The test was added by commit 0ddbf47 in issue #66652 which added _PyTraceback_Add().

    Quickly, the test was skipped if sysconfig.is_python_build() is false: commit 2b3b95b.

    In 2022, the test was skipped on WASM and Win32 ARM: commit 96b344c. These two platforms build Python with cross-compilation: the target Python doesn't have access to Python C source code. A minor follow-up also skipped the test on WASI: commit 9b50585.

    IMO the condition to decide to skip the test or not is weak. And the test should not depend on which directory tests are run.

  6. vstinner
    added 2 commits that reference this issue on Sep 10, 2023

    pythongh-109230: test_pyexpat no longer depends on the current directory

    bcb68cc

    pythongh-109230: test_pyexpat no longer depends on the current directory

    8913133

  7. vstinner commented on Sep 10, 2023

    @vstinner
    vstinner
    on Sep 10, 2023
    MemberAuthor

    Oh wait. Maybe it's a real bug in my PR #109229.

    My PR makes the issue easier to reproduce since running the Python test suite with -j1 option changes the current working directory and so trigger the bug.

  8. vstinner
    added 2 commits that reference this issue on Sep 10, 2023

    pythongh-109230: test_pyexpat no longer depends on the current directory

    102737f

    gh-109230: test_pyexpat no longer depends on the current directory (#…

    e55aab9
  9. miss-islington
    added 2 commits that reference this issue on Sep 10, 2023

    pythongh-109230: test_pyexpat no longer depends on the current direct…

    e467547

    pythongh-109230: test_pyexpat no longer depends on the current direct…

    8508536
  10. vstinner
    closed this as completedon Sep 10, 2023
  11. vstinner
    added a commit that references this issue on Sep 10, 2023

    [3.11] gh-109230: test_pyexpat no longer depends on the current direc…

    a7e80fb
  12. Yhg1s
    added a commit that references this issue on Sep 12, 2023

    [3.12] gh-109230: test_pyexpat no longer depends on the current direc…

    df64210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions