You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @erlend-aasland / @serhiy-storchaka - I'm a test engineer and would love to contribute to Python. Been using it for 9+ years. Any chance of taking a look at this issue?
Edit: I guess master is not what we merge into lol, what's the working branch to merge into? Pulled master for this work
The development branch is called main (currently 3.13 development). Apart from that, we've got release branches (3.12, 3.11, etc.). You're free to choose your own branching scheme when developing. I used to name bug/feature branches using the issue number, but nowadays I group them using a simple naming scheme instead: sqlite/* for sqlite3 stuff, clinic/* for Argument Clinic stuff, docs/* for random documentation stuff, and for everything else, I just make up a name there and then :)
Note: all PRs are squashed into a single merge commit in main, so you don't have to worry about the PR/branch history; it is ok if it is messy! See also the devguide.
Thank you for your test @EddInSverige, but other tests look unneeded to me.
After looking more closely, I also see that we've got these cases covered already. Thanks, @EddInSverige, but I agree with Serhiy that #108628 is not needed.
Activity
EddInSverige commentedon Aug 28, 2023
Hey @erlend-aasland / @serhiy-storchaka - I'm a test engineer and would love to contribute to Python. Been using it for 9+ years. Any chance of taking a look at this issue?
erlend-aasland commentedon Aug 28, 2023
Great, have a go at it! :) I'll get a ping when you create the PR.
EddInSverige commentedon Aug 28, 2023
@erlend-aasland I added a single test just to check the whole build/test workflow etc - happy to add more tomorrow. Does the PR itself look okay?
Edit: I guess master is not what we merge into lol, what's the working branch to merge into? Pulled master for this work
Merge branch 'python:main' into pythongh-108558-fix
erlend-aasland commentedon Aug 29, 2023
The development branch is called
main(currently 3.13 development). Apart from that, we've got release branches (3.12,3.11, etc.). You're free to choose your own branching scheme when developing. I used to name bug/feature branches using the issue number, but nowadays I group them using a simple naming scheme instead:sqlite/*for sqlite3 stuff,clinic/*for Argument Clinic stuff,docs/*for random documentation stuff, and for everything else, I just make up a name there and then :)Note: all PRs are squashed into a single merge commit in
main, so you don't have to worry about the PR/branch history; it is ok if it is messy! See also the devguide.EddInSverige commentedon Aug 29, 2023
Okay great! So I guess my PR is all good then?
If so I'll dig out some more test issues and have a go at them :)
[-]Add tests for sqlite3.Row.keys()[/-][+]Add explicit test for sqlite3.Row.keys()[/+]2 remaining items
gh-108558: Improve sqlite3 row factory tests (#108578)
pythongh-108558: Improve sqlite3 row factory tests (pythonGH-108578)
pythongh-108558: Improve sqlite3 row factory tests (pythonGH-108578)
[3.11] gh-108558: Improve sqlite3 row factory tests (GH-108578) (#108616
pythongh-108558: Improve sqlite3 row factory tests (pythonGH-108578)
EddInSverige commentedon Aug 29, 2023
I added a second PR to cover the edge case that the SQL query didn't return any results and a few other behaviours
serhiy-storchaka commentedon Aug 29, 2023
Thank you for your test @EddInSverige, but other tests look unneeded to me.
erlend-aasland commentedon Aug 29, 2023
After looking more closely, I also see that we've got these cases covered already. Thanks, @EddInSverige, but I agree with Serhiy that #108628 is not needed.
[3.12] gh-108558: Improve sqlite3 row factory tests (GH-108578) (#108615