Repository navigation
[C API] Use new PyDict_GetItemRef() C API #108308
Description
Bug report
Checklist
- I am confident this is a bug in CPython, not a bug in a third-party project
- I have searched the CPython issue tracker,
and am confident this bug has not been reported before
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Output from running 'python -VV' on the command line:
No response
A clear and concise description of the bug:
Calls to PyDict_GetItem() should be replaced with PyDict_GetItemRef().
PyDict_GetItemWithError() may also be replaced with PyDict_GetItemRef().
Linked PRs
- gh-108308: Replace PyDict_GetItem() with PyDict_GetItemRef() #108309
- gh-108308: config_dict_get() uses PyDict_GetItemRef() #108371
- gh-108308: Replace _PyDict_GetItemStringWithError() #108372
- gh-108308: Use PyDict_GetItemRef() in moduleobject.c #108381
- gh-108308: Remove _PyDict_GetItemStringWithError() function #108426
Activity
pythongh-108308: Replace PyDict_GetItem() with PyDict_GetItemRef()
pythongh-108308: Replace PyDict_GetItem() with PyDict_GetItemRef()
gh-108308: Replace PyDict_GetItem() with PyDict_GetItemRef() (#108309)
pythongh-108308: config_dict_get() uses PyDict_GetItemRef()
pythongh-108308: config_dict_get() uses PyDict_GetItemRef()
pythongh-108308: Replace _PyDict_GetItemStringWithError()
pythongh-108308: Replace _PyDict_GetItemStringWithError()
pythongh-108308: Replace _PyDict_GetItemStringWithError()
pythongh-108308: Replace _PyDict_GetItemStringWithError()
pythongh-108308: Replace _PyDict_GetItemStringWithError()
gh-108308: Replace _PyDict_GetItemStringWithError() (#108372)
gh-108308: config_dict_get() uses PyDict_GetItemRef() (#108371)
pythongh-108308: Use PyDict_GetItemRef() in moduleobject.c
pythongh-108308: Use PyDict_GetItemRef() in moduleobject.c
gh-108308: Use PyDict_GetItemRef() in moduleobject.c (#108381)
pythongh-108308: Remove _PyDict_GetItemStringWithError() function
gh-108308: Remove _PyDict_GetItemStringWithError() function (#108426)
vstinner commentedon Aug 24, 2023
PyDict_GetItem() and PyDict_GetItemString() are no longer used in Python code base.
I added PyDict_ContainsString() and removed the _PyDict_GetItemStringWithError() function.
I consider that the work is now done here, I close the issue. Thanks to everyone who helped with reviews :-)