You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sometimes input checks are missing (e.g. L989 of math_1 or L1023 of math_1a), sometimes exceptional cases are not tested (e.g. in fsum), some code is just inaccessible (like L3519 in the perm_comb_small() helper). See attached coverage report (for ./python -m test test_math).
I believe, everything should be tested (except for memory errors and similar special cases).
@hauntsaninja, wait. As I said in the PR thread - there are still some uncovered lines/branches. I think it's worth to keep this issue open until it's fixed completely.
Activity
pythongh-102837: few coverage nitpicks for the math module
gh-102837: improve test coverage for math module (#102523)
skirpichev commentedon Sep 3, 2023
@hauntsaninja, wait. As I said in the PR thread - there are still some uncovered lines/branches. I think it's worth to keep this issue open until it's fixed completely.
hauntsaninja commentedon Sep 3, 2023
Ah, missed that since it was early on. Re-opened!
pythongh-102837: Increase test coverage for the math module
pythongh-102837: Increase test coverage for the math module
pythongh-102837: more tests for the math module
gh-102837: more tests for the math module (GH-111930)
[3.12] pythongh-102837: more tests for the math module (pythonGH-111930)
pythongh-102837: more tests for the math module (pythonGH-111930)
pythongh-102837: improve test coverage for math module (python#102523) (
pythongh-102837: more tests for the math module (pythonGH-111930)
[3.12] gh-102837: more tests for the math module (GH-111930)(GH-102523)…
[3.11] gh-102837: more tests for the math module (GH-111930)(GH-102523)…
pythongh-102837: more tests for the math module (pythonGH-111930)
pythongh-102837: more tests for the math module (pythonGH-111930)