Skip to content

Reduce _idle_semaphore calls in ThreadPoolExecutor #102024

Closed
Closed
Reduce _idle_semaphore calls in ThreadPoolExecutor#102024
Labels
performancePerformance or resource usagestdlibStandard Library Python modules in the Lib/ directorytype-featureA feature request or enhancement

Description

@jackcvr
jackcvr
opened on Feb 18, 2023

Feature or enhancement

In concurrent.futures.thread.ThredPoolExecutor method executor._idle_semaphore.release() should be called if only work queue is empty

Pitch

Currently _idle_semaphore.release() is called after processing every item in queue. That produces useless semaphore updates in case when queue still has items to process.
The optimization is going to increase processing speed of work queue.

Linked PRs

Activity

  1. jackcvr
    added
    type-featureA feature request or enhancement
    on Feb 18, 2023
  2. arhadthedev
    added
    stdlibStandard Library Python modules in the Lib/ directory
    on Feb 18, 2023
  3. arhadthedev
    added this to Threading issues 🧵on Feb 18, 2023
  4. jackcvr
    changed the title [-]Reduce IDLE semaphore calls[/-] [+]Reduce IDLE semaphore calls in ThreadPoolExecutor[/+] on Feb 18, 2023
  5. terryjreedy
    changed the title [-]Reduce IDLE semaphore calls in ThreadPoolExecutor[/-] [+]Reduce _idle_semaphore calls in ThreadPoolExecutor[/+] on Feb 18, 2023

  6. terryjreedy commented on Feb 18, 2023

    @terryjreedy
    terryjreedy
    on Feb 18, 2023
    Member

    'IDLE' (capitalized) is the IDE that comes with CPython; it has nothing to do with inactivity ;-).

  7. gpshead
    added a commit that references this issue on May 26, 2023

    gh-102024: Reduced _idle_semaphore.release calls (#102025)

    0242e9a
  8. miss-islington
    added a commit that references this issue on May 26, 2023

    pythongh-102024: Reduced _idle_semaphore.release calls (pythonGH-102025)

    48d7818
  9. gpshead
    added
    performancePerformance or resource usage
    on May 26, 2023

  10. gpshead commented on May 26, 2023

    @gpshead
    gpshead
    on May 26, 2023
    Member

    thanks!

  11. gpshead
    closed this as completedon May 26, 2023
  12. github-project-automation
    moved this to Done in Threading issues 🧵on May 26, 2023
  13. gpshead
    added a commit that references this issue on May 26, 2023

    [3.12] gh-102024: Reduced _idle_semaphore.release calls (GH-102025) (#…

    8010cef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    performancePerformance or resource usagestdlibStandard Library Python modules in the Lib/ directorytype-featureA feature request or enhancement

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions