Repository navigation
pathlib.PureWindowsPath.match() mishandles path anchors #101360
Description
pathlib.PurePath.match() doesn't use fnmatch() to match path anchors, contrary to the documentation. Instead, it considers the drive and root of the pattern separately; if either (or both) is specified in the pattern, it must exactly match the corresponding drive/root in the path.
This results in the following:
>>> from pathlib import PureWindowsPath as P
>>> P('c:/b.py').match('*:/*.py')
False
>>> P('c:/b.py').match('c:*.py')
True
>>> P('c:/b.py').match('/*.py')
True
>>> P('//some/share/a.py').match('//*/*/*.py')
False
>>> P('//some/share/a.py').match('/*.py')
TrueAll of these results are wrong IMO.
Activity
barneygale commentedon Jan 27, 2023
I think I know why this behaviour is here: pathlib originally wouldn't parse patterns like
*:/because it required drive letters to be alphabetic.match()worked around this by treating empty drives like*.The alphabetic drive requirement was removed in 2ba0fd5 (3.12).
pythongh-101360: Fix anchor matching in pathlib.PureWindowsPath.match()
pythongh-101360: Fix anchor matching in pathlib.PureWindowsPath.match()
Merge branch 'main' into pythongh-101360-fix-match-partial-anchor
gh-101360: Fix anchor matching in pathlib.PureWindowsPath.match() (GH…
barneygale commentedon Feb 17, 2023
Fixed in #101363 / d401b20