Repository navigation
Conversation
Currently --pr-remote defaults to origin but for cpython many repos need at least two remotes. Remembering to provide --pr-remote every time is hard, so make a way of providing a value. Chose to reuse git's existing config option to minimize cherry_picker specific infrastructure and documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--pr-remotedefaults toorigin. Anyone whose fork remote has another name has to pass the flag on every call, including--continue. Forgetting it on--continuefails the push, and the backport branch is deleted anyway (#78).Proposal: if
--pr-remoteisn't given, usegit config remote.pushDefault, falling back toorigin. That's Git's standard "where my pushes go" setting, so per-repo,--globalandincludeIfsetups all work without cherry_picker needing a config surface of its own. Users who don't set it see no change.Precedent:
preferences.toml) and were closed for lack of interest (decision, #37 close). This proposal adds no new settings and only reads one Git already has.cherry_picker --continue#8 (open):--continuedoesn't remember--pr-remote(original analysis). Readingremote.pushDefaulton every call fixes that for anyone who sets it.Developed with AI (Claude Opus 5.5)