Skip to content

Support logging in with GitHub #7

Closed

Description

@Mariatta

It would be great if we can login to bpo using GitHub.

Thanks.

Activity

  1. ammaraskar commented on Jun 20, 2018

    @ammaraskar
    Member

    Setup Instructions

    Generate a set of github oauth credentials here:
    https://github.com/settings/applications/new

    Set the authorization callback url to be:
    https://bugs.python.org/index?@action=oic_authresp&provider=Github

    Insert the client_id and client_secret into the database:

    INSERT INTO _oic_registration 
      (_issuer, _client_id, _client_secret, id) 
      VALUES ('https://github.com/settings/developers', 'xx', 'xx', x);

    Patch

    Applies to tracker/python-dev

    https://gist.github.com/ammaraskar/e259bc7d50df354e796e3c0d61137b10

  2. ammaraskar commented on Jun 20, 2018

    @ammaraskar
    Member

    @ezio-melotti Antoine said you'd be the right person to talk to about getting this merged. Lemme know if you want the patch in some specific way or another.

  3. ewdurbin commented on May 21, 2019

    @ewdurbin
    Member

    A GitHub application managed by the python organization has been created with the name bugs.python.org and configured as directed above.

  4. Mariatta commented on Aug 8, 2019

    @Mariatta
    MemberAuthor

    I still have not figured out how to register/login to bpo using GitHub account 😟
    Has the patch been merged? @ammaraskar @ezio-melotti?

  5. ammaraskar commented on Aug 8, 2019

    @ammaraskar
    Member

    @berkerpeksag might also be able to answer, I think they mentioned this was disabled for some reason.

  6. berkerpeksag commented on Aug 8, 2019

    @berkerpeksag
    Member

    It wasn't fully deployed for end users. By default, GitHub API doesn't include email addresses of users even if we set the OAuth scope correctly (users need to make their email address public on GitHub or we need to make a request to another endpoint in order to get their email address)

    I'm not going to work on it until I get a response from Barry regarding PEP 595.

  7. self-assigned this
    on Aug 1, 2020
  8. berkerpeksag commented on Aug 10, 2020

    @berkerpeksag
    Member

    I've just re-pushed the patch with some modifications. I've already tested both Google and GitHub login supports locally. It should detect and associate existing bugs.python.org accounts with the same email address.

    The only limitation is that the email address must be set to public in user's email settings at GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions