Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Preserve the offset of time-only strings
pendulum.parse("20:12:05+05:30")loses the explicit offset when the parsed time is normalized to today's datetime. The result is interpreted as UTC (or the fallbacktzoption), changing the instant by several hours. Full datetime strings already retain their explicit offsets.Pass the parsed time's
tzinfointo the normalized datetime. Twelve regression cases exercise the low-level and public parsers with positive, negative, zero, andZoffsets, including an explicit fallback timezone. On the unchanged implementation, 10 cases fail and 2 controls pass.Validation on Linux / Python 3.13:
git diff --check: passed.The parsing documentation now includes a time-only offset example. Prepared and validated with AI assistance (OpenAI Codex).