[cansarigol]

USERINFO_RE regex pattern separates URL by first @ character. I changed this pattern to evaluate the last @ character so that can use an email address for userinfo.username (e.g. "https://user@gmail.com:password@example.com")

[cansarigol]

HI @sethmlarson could you review this pr.

[sigmavirus24]

There's no description for why this is important. All it says is that it "Fixed" something which is correct per the ABNF.

[cansarigol]

This fix about using email address for userinfo.username
e.g. "https://user@gmail.com:password@example.com". Email address is quite used as a username. But using in url I'm not sure. Hence I don't know how important it is.

in Httpx project we had a problem with this (issue328) and as per ticket, @sethmlarson wrote that we can fix rfc3986. Because of that, I wanted to push a commit to fix this problem.

As far as I understood, USERINFO_RE regex pattern separates URL by first @ character. I changed this pattern to evaluate the last @ character.

[sigmavirus24]

That's all great context that belongs in the commit message and pull request description.

[oczkers]

Can we get it merged?

[sigmavirus24]

This is still not compliant with the RFC. The @ in the email must be encoded for it to be passed correctly